vscode: Orca can't be stopped in native dialogs
Issue Type: Bug
open any native dialog about or check for updates. press ctrl to stop speech. orca should stop talking.
this issue similar to #93056
VS Code version: Code - Insiders 1.56.0-insider (b4816cfd1f4161a3bb272354d181a9947760ee26, 2021-04-20T07:24:33.853Z) OS version: Linux x64 5.11.15-arch1-2
System Info
| Item | Value |
|---|---|
| CPUs | Intel® Celeron® CPU 1005M @ 1.90GHz (2 x 1900) |
| GPU Status | 2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: disabled_off oop_rasterization: disabled_off opengl: enabled_on rasterization: disabled_software skia_renderer: enabled_on video_decode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled |
| Load (avg) | 2, 1, 1 |
| Memory (System) | 3.70GB (0.64GB free) |
| Process Argv | –no-sandbox --crash-reporter-id 9fe453d7-430e-46b5-bfd9-60af52319e71 |
| Screen Reader | yes |
| VM | 0% |
| DESKTOP_SESSION | mate |
| XDG_CURRENT_DESKTOP | MATE |
| XDG_SESSION_DESKTOP | mate |
| XDG_SESSION_TYPE | x11 |
Extensions (40)
| Extension | Author (truncated) | Version |
|---|---|---|
| meson | asa | 1.3.0 |
| github-markdown-preview | bie | 0.0.2 |
| markdown-checkbox | bie | 0.1.3 |
| markdown-emoji | bie | 0.1.0 |
| markdown-preview-github-styles | bie | 0.2.0 |
| markdown-yaml-preamble | bie | 0.0.4 |
| vscode-astyle | chi | 0.9.0 |
| systemd-unit-file | coo | 1.0.6 |
| vscode-github-actions | csc | 0.17.0 |
| vscode-markdownlint | Dav | 0.40.3 |
| githistory | don | 0.6.16 |
| gitlens | eam | 11.4.1 |
| EditorConfig | Edi | 0.16.4 |
| vscode-pull-request-github-insiders | Git | 2021.4.29343 |
| markdown-extended | jeb | 1.0.19 |
| better-cpp-syntax | jef | 1.15.5 |
| restructuredtext | lex | 148.0.0 |
| kconfig | luv | 1.0.3 |
| vscode-docker | ms- | 1.12.1 |
| vscode-language-pack-ru | MS- | 1.55.2 |
| python | ms- | 2021.5.746022950-dev |
| vscode-pylance | ms- | 2021.4.1 |
| jupyter | ms- | 2021.6.751425733 |
| remote-containers | ms- | 0.169.0 |
| remote-ssh | ms- | 0.65.4 |
| remote-ssh-edit | ms- | 0.65.4 |
| remote-wsl | ms- | 0.56.0 |
| cmake-tools | ms- | 1.7.0 |
| cpptools | ms- | 1.3.1 |
| cpptools-extension-pack | ms- | 1.0.0 |
| vsliveshare | ms- | 1.0.4131 |
| vsliveshare-audio | ms- | 0.1.91 |
| vsliveshare-pack | ms- | 0.4.0 |
| vscode-yaml | red | 0.18.0 |
| platform-settings | run | 0.0.2 |
| rewrap | stk | 1.14.0 |
| code-spell-checker | str | 1.10.2 |
| code-spell-checker-russian | str | 0.2.9 |
| cmake | twx | 0.0.17 |
| grammarly | znc | 0.14.0 |
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvspyt639:30291487
pythontb:30258533
vspre833cf:30267465
pythonptprofiler:30281269
vsdfh931cf:30280410
vscnewfiletextcf:30288478
vshan820:30276952
pythondataviewer:30285072
vscus158:30286553
vscgsv2:30286872
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 51 (16 by maintainers)
I can take a look later, but if Orca doesn’t interrupt speech and Orca commands fail to work then that means Orca is not being notified of input events.
@isidorn we essentially need 1 of the following 2 things for a fix.
Implement a libportal-based file chooser dialog in Electron or inherit the file chooser dialogs from Chromium. I brought this up in the linked Electron issue somewhere above, but there has been no movement from their side.
The other option is to just revert the offending Electron commits.
I ended up not mentioning it in my previous comment, but the flat review mode is also working in this case.
@jvesouza thanks for the ping. I know @deepak1556 has this on the plan and plans to investigate more this or next milestone. I expect us to have more details soon. Thank you for your understanding.
@isidorn yup sounds good, we would first need to refactor the dialog implementation in Electron https://github.com/electron/electron/pull/35110#issuecomment-1200044072
I am optimistically adding this to February 2023 milestone.
@jvesouza thanks for the ping. @deepak1556 maybe we try to put this on the plan some time in the future, what do you think?
fyi @meganrogge
There is discussion in https://github.com/electron/electron/pull/35110 to refactor the file dialog implementation to reuse implementation from chromium and I believe that would allow to resolve this issue as well. I need to check with Electron maintainers to see if this is already on plan for this month.
So I see new VSCode has been released. I will look into this this week. I think there is one PR that can be submitted to electron upstream, which is re-adding that gobject_set_data() referenced in the other comment. I will see if I can reproduce the issue after making that change and let you all know. Otherwise, I will have to look into Wayland and X11 stuff…ugh. Hard to find people who are knowledgeable enough (about this relationship between GtkFileChooserNative, accessibility on Linux, X11, and Wayland) and actually care. If anyone knows someone at Canonical or Igalia, now is the time to reach out. Would hate for people relying on screen reading to have a permanent disadvantage when using Electron applications on Linux.