vscode: Menu: Linux "native" menu on insiders has grey text that does not offer a high enough contrast with the black background

Wen using the native title bar style, menu text is a darkish grey that is hard to read on a black background(see screenshot). If using the custom style, text is white and thinsg are ok.

VSCode Version: 1.29 insiders
OS Version: Ubuntu 18.04 with Linux 4.18.13 x64

Steps to Reproduce:

Open Code
Look at the menu

Does this issue occur when all extensions are disabled?: Yes

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 1
Comments: 15 (4 by maintainers)

Most upvoted comments

@wk that was the conclusion that I originally came to; however, it turns out, the electron change to honor GTK theme preferences was incomplete. Now electron honors the menubar background color but uses the incorrect foreground color. Instead, the menubar foreground color is sourced from the context menu foreground color. Since Yaru uses a black bg with white text for the menubar and a white bg with black text for the context menus, you get black text on a black bg.

sbatten on Nov 16, 2018

@vide the issue you are seeing appears to be the issue in electron/electron#14785 - which has been fixed in newer versions of Electron; this change is present in current versions of code-insiders (Electron 2.0.11) and code-exploration (Electron 3.0.4) - but not in the current stable code (which relies on Electron 2.0.9).

Thus, getting the GTK theme colors through in the menu bar will require you currently to move to code-insiders or code-exploration. However, once you’ve done so - you may encounter the very bug this issue is about: invisible menu bar text on the Ubuntu Yaru theme. This issue remains in current builds.

wk on Oct 19, 2018