vscode: JAWS: focus on buttons does not announce their specific label
Issue Type: Bug
I have noticed that many of the buttons in the workbench have lost their accessibility labels. When arrowing with a screen reader, buttons like the “more options” used to bring up the context menu for an option in theJSON editor merely say “button” now. Is there any change we need to make?
VS Code version: Code 1.66.0 (e18005f0f1b33c29e81d732535d8c0e47cafb0b5, 2022-03-30T05:50:14.623Z) OS version: Windows_NT x64 10.0.19044 Restricted Mode: No
System Info
| Item | Value |
|---|---|
| CPUs | Intel® Core™ i7-10710U CPU @ 1.10GHz (12 x 1608) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled |
| Load (avg) | undefined |
| Memory (System) | 63.81GB (54.04GB free) |
| Process Argv | –crash-reporter-id 9a4aa34a-281b-4490-b3fa-a00ab49c2ab6 |
| Screen Reader | yes |
| VM | 40% |
Extensions (15)
| Extension | Author (truncated) | Version |
|---|---|---|
| remotehub | Git | 0.28.0 |
| vscode-home-assistant | kee | 1.27.0 |
| python | ms- | 2022.1.1845711884-dev |
| vscode-pylance | ms- | 2022.3.4 |
| jupyter | ms- | 2022.3.1000901801 |
| jupyter-keymap | ms- | 1.0.0 |
| jupyter-renderers | ms- | 1.0.6 |
| remote-containers | ms- | 0.231.2 |
| remote-ssh | ms- | 0.78.0 |
| remote-ssh-edit | ms- | 0.78.0 |
| remote-wsl | ms- | 0.66.0 |
| vscode-remote-extensionpack | ms- | 0.21.0 |
| powershell | ms- | 2021.12.0 |
| remote-repositories | ms- | 0.4.0 |
| vscodeintellicode | Vis | 1.2.18 |
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vsclayoutctrt:30451275
dsvsc009:30452663
pythonvsnew555:30457759
vscscmwlcmt:30438805
vscgsvidc:30447482
pynewfile477cf:30450039
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 17 (7 by maintainers)
Commits related to this issue
- set aria-label on actions so JAWS also reads it #146658 — committed to microsoft/vscode by isidorn 2 years ago
Updating with link to Vespero issue
A quick look at Code Insiders with JAWS indicates that the buttons in question actually have content, albeit a single character in the private Unicode range. JAWS assumes therefor that the buttons have text and looks no further. Although these buttons have title attributes, JAWS doesn’t use them because the button’s text is generally thought of as being more concise. The tooltip is consumed as a fallback if there is no explicit aria-label and no text within the button. We could modify a future update of JAWS 2022 to account for the private Unicode range, but it feels like this is a case for an explicit label, to override the button contents.
I’m looking at a toolbar with buttons like “Customize Layout,” “Toggle Primary Side Bar, ” “Toggle Panel (Ctrl+j),” etc. These are things for which JAWS just says button.
Does the above map to what you’re seeing in the code?
I have definitely anticipated that being the case, so I did a bit of testing – I set up an older version of JAWS that previously worked with older versions of VSCode on a clean VM and reproduced the same behaviour with the current release build and the insider build. Is there anything that could have changed in recent releases of VSCode that would have broke the JAWS support? I’m sure @ggordon-vispero would probably appreciate that tidbit if it was available. 😃 Please let me know either way, and if nothing can be added to this issue, I can close and open a bug with FS. Thanks.