vscode: "IPersistFile::Save failed" during installation of VS Code Insiders
- VSCode Version: 1.48.0-insider (user setup)
- OS Version: Windows_NT x64 10.0.19041
Commit: db40434f562994116e5b21c24015a2e40b2504e6 Date: 2020-08-11T23:21:50.282Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0
Steps to Reproduce:
- Download and run “VSCodeUserSetup-x64-1.48.0-insider.exe”
I’m not sure if it’s relevant, but I had VS stable installed prior to the Insiders install. Also, I tried to remove stable and reinstall Insiders, which resulted in the same error. It seems like everything is functioning properly, but there’s no shortcut on the desktop.
Does this issue occur when all extensions are disabled?: Yes
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 31 (13 by maintainers)
@Maxim-Mazurok thanks a lot. We figured out that it did not fix the issue. We have another candidate that is being built now, soon it will be out and I will share the links so you can try again. Really appreicate the help.
I believe “Create desktop shortcut” option may be producing this error.
Great. It also worked for me.
So to recap: The inno-updated update broke this. We are looking into two options for the recovery build:
We will decide on which one to do depending on the risk. We will not revert back to the old inno-update version due to other chagnes that have gone in.
fyi @lszomoru @deepak1556
Sorry about the early conclusion, a bit more investigation looking at the logs of
1.47.3installation, it does install the shortcut link under the desktop for current user rather than public folder. So this behavior change with1.48is indeed a bug.Looking at the changelog, the only relevant changes that went into the setup code path are https://github.com/microsoft/vscode/commit/5f5b75a746c8f4e2a7e583bb17a2a493dd04e4a6 https://github.com/microsoft/vscode/commit/cbc8bd84ae67ba8b2f6dbc1cf582560a6e1f15ce , will check if the change in setup style brought in this behavior.
I have the same issue on Windows 7 - and seems like the checked “install link on the desktop” causes the problem, as at the end of installation VS saying “installed fine” and it’s running OK.
I tried to uninstall and install again, but checked only the PATH option. All other options was left unchecked. No error happend. I don’t know if was coincidence or that others checked options were causing the error.