vscode: inline suppress suggestions doesn't work anymore

Type: Bug

Seems like newest VS Code version (1.79.0) broke down "editor.inlineSuggest.suppressSuggestions": false. If I type . (dot) or text while inline suggestions are visible suggest widget doesn’t show anymore, I need to trigger it manually. In previous version it showed even when inline suggestions were visible.

image

https://github.com/microsoft/vscode/assets/10441177/ac59b439-ec8e-43c8-95c0-06b25c84d449

Code snippet
class User {
  get userId() {
    return "userId"
  }
}

const user = new User()

user

VS Code version: Code 1.79.0 (b380da4ef1ee00e224a15c1d4d9793e27c2b6302, 2023-06-07T14:31:03.317Z) OS version: Darwin arm64 22.5.0 Modes:

System Info
Item Value
CPUs Apple M1 Pro (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 2, 2, 3
Memory (System) 32.00GB (1.08GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (12)
Extension Author (truncated) Version
vscode-eslint dba 2.4.0
gitlens eam 13.6.0
prettier-vscode esb 9.13.0
copilot Git 1.88.132
vscode-graphql Gra 0.8.13
vscode-graphql-syntax Gra 1.2.0
symbols mig 0.0.11
vscode-react-native msj 1.11.0
vscode-thunder-client ran 2.7.6
vscode-fileutils sle 3.10.1
vim vsc 1.25.2
quokka-vscode Wal 1.0.543

(1 theme extensions excluded)

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 19 (14 by maintainers)

Most upvoted comments

@svipas thanks, that’s the result I’m looking for.

Good points. I expect that we get this resolved in the next month or so.

@isidorn Time is passing and I don’t see any changes from Copilot side.

Shouldn’t VS Code have priority to control this behavior? So such extensions as Copilot wouldn’t have any control other this, because I assume this could happen again, and also setting suppressSuggestions is coming from VS Code so it kinda makes sense that VS Code should be in full control. Because now even though setting exists in VS Code, extension controls behavior so that setting should be in extension not in VS Code (my opinion).

Sorry if this sounds like a push, I’m just actually curious why VS Code is not the one who controls it fully instead of giving control to extension which as we could see is not a good thing, because this problem exists and could be repeated again…

@isidorn Didn’t know that, thanks for info. I really like suppressSuggestions setting, previously it was kinda annoying how Copilot tried to predict everything and suggest widget was not showing up, so I’m really keen to have this functionality back. This setting with Copilot is match made in heaven 😃

@svipas thanks for opening this issue but the Copilot team is aware of this and @smalllemur is driving this effort on the GitHub Copilot side. I expect this to be fixed soon-ish. Fabien has more details.