vscode: Incorrect $PATH order in task shell

I think this one is probably related: https://github.com/microsoft/vscode/issues/186244

I’m also adopting the source ~/.zshrc && in the command workaround suggested in that linked issue, seems like the only thing that works for now

I’m not sure why it would be breaking anything for you though 🤔

Changing the order of the path breaks a lot of things for me, it is loading system versions of things like Ruby etc instead of my local ones 😅 I tried to override the behavior with options.env.PATH but that gets blown away too.

I am a little surprised that there’s not more activity on this issue, my environment must be weirder than I thought, because I thought this would have blown a lot of people up

@meganrogge I wonder if it’s due to this commit. Not sure if this is in 1.80. https://github.com/microsoft/vscode/commit/ca9192e80b096d715378e905fc074723924bad10

It’s strange that the PR this commit references (https://github.com/microsoft/vscode/pull/186938) seems to just be for performance but the commit seems to remove fetching the shell env.

This worked as expected with the following version of vscode:

Version: 1.79.2
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:58:33.551Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 23.3.0

And was broken on the following version:

Version: 1.80.2
Commit: 2ccd690cbff1569e4a83d7c43d45101f817401dc
Date: 2023-07-27T20:57:59.134Z
Electron: 22.3.14
ElectronBuildId: 22695494
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 23.3.0

This is also a problem for me when using Conda python environments because the system version of python is selected instead of the version used in the environment.

macOS terminal:

> echo $PATH | tr ':' '\n'
/Users/*****/miniconda3/envs/test/bin
/Users/*****/miniconda3/condabin
/usr/local/bin
/System/Cryptexes/App/usr/bin
/usr/bin
/bin
/usr/sbin
/sbin
/Library/Apple/usr/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
> conda info --env
# conda environments:
#
base                     /Users/*****/miniconda3
test                  *  /Users/*****/miniconda3/envs/test
> which -a python3
/Users/*****/miniconda3/envs/test/bin/python3
/usr/bin/python3

Inside vscode task:

> echo $PATH | tr ':' '\n'
/usr/local/bin
/System/Cryptexes/App/usr/bin
/usr/bin
/bin
/usr/sbin
/sbin
/Library/Apple/usr/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
/Users/*****/miniconda3/envs/test/bin
/Users/*****/miniconda3/condabin
> conda info --env
# conda environments:
#
base                     /Users/*****/miniconda3
test                  *  /Users/*****/miniconda3/envs/test
> which -a python3
/usr/bin/python3
/Users/*****/miniconda3/envs/test/bin/python3

I have the same issue.

Version: 1.81.1
Date: 2023-08-09T22:18:39.991Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux x64 6.4.11-arch2-1

Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794

.vscode/tasks.json

{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "echo PATH",
      "type": "shell",
      "command": "echo $PATH | tr ':' '\\n'"
    }
  ],
}

Executing the task

 *  Executing task: echo $PATH | tr ':' '\n' 

/usr/local/bin
/usr/bin
/usr/local/sbin
/var/lib/flatpak/exports/bin
/usr/bin/site_perl
/usr/bin/vendor_perl
/usr/bin/core_perl
 *  Terminal will be reused by tasks, press any key to close it. 

From terminal

$ echo $PATH | tr ':' '\n'
/home/us-er/.local/share/rtx/installs/node/18.17.1/bin
/home/us-er/.local/share/rtx/installs/go/1.21.0/go/bin
/home/us-er/.local/share/rtx/installs/go/1.21.0/packages/bin
/home/us-er/.local/share/rtx/installs/java/openjdk-17/bin
/home/us-er/.local/share/rtx/installs/nim/2.0.0/bin
/home/us-er/.local/share/rtx/installs/nim/2.0.0/nimble/bin
/home/us-er/.local/share/rtx/installs/rust/1.72.0/bin
/home/us-er/.local/share/rtx/installs/bin/0.17.0/bin
/home/us-er/.local/share/rtx/installs/pipx/1.2.0/bin
/home/us-er/.local/share/rtx/installs/zig/0.11.0/bin
/home/us-er/.local/share/rtx/installs/shfmt/3.7.0/bin
/home/us-er/.local/share/rtx/installs/ninja/1.11.1/bin
/home/us-er/.local/share/rtx/installs/neovim/0.9.1/bin
/home/us-er/.local/share/rtx/installs/kotlin/1.9.10/kotlinc/bin
/home/us-er/.local/share/rtx/installs/kotlin/1.9.10/kotlin-native/bin
/home/us-er/.local/share/rtx/installs/cmake/3.27.4/bin
/home/us-er/.local/share/rtx/installs/meson/1.2.1/bin
/home/us-er/.local/share/rtx/installs/shellcheck/0.9.0/bin
/usr/local/bin
/usr/bin
/usr/local/sbin
/var/lib/flatpak/exports/bin
/usr/bin/site_perl
/usr/bin/vendor_perl
/usr/bin/core_perl
/home/us-er/.local/bin

---

Current work around:

~/.zprofile

# ~/.zprofile

# Import the default profile
if [ -f "/etc/profile" ]; then
    # shellcheck disable=SC1091
    . "/etc/profile"
fi

# Append "$1" to $PATH when not already in.
append_path() {
    case ":$PATH:" in
    *:"$1":*) ;;
    *)
        export PATH="${PATH:+$PATH:}$1"
        ;;
    esac
}

# user-paths
append_path "$HOME/.local/bin"
eval "$(/usr/bin/rtx activate zsh)"
#append_path "$HOME/.local/share/rtx/shims" # slower

unset -f append_path

@meganrogge @Tyriar can you reopen this issue? It’s still a problem. What information do you need from me to help resolve it?

@ryanb in which case I think it is expected since the builtin git extension uses this API