vscode: Images in hover preview are broken with vscode 1.53/1.54

  • VS Code Version: 1.54.3
  • OS Version: macOS 11.2.1

Does this issue occur when all extensions are disabled?: Yes/No

Hi, I’m dev of vscode-memo extension and noticed that images are no longer rendered in hover preview in latest versions, it used to work in 1.52 version though.

This is how it looks in 1.54 (should show backlinks panel image on link hover instead of broken image icon):

image

When I try to open img src by copying it from DevTools (notice that network tab shows this src in red and status = cancelled) directly in Chrome, it opens just fine and shows an image, so path is valid at least.

image

This is how it used to look in 1.52:

image

Related code: https://github.com/svsool/vscode-memo/blob/92e869c81d4ce9906564438eec8af242ff644c85/src/features/ReferenceHoverProvider.ts#L56

Steps to Reproduce:

Install vscode-memo (ensure to choose “install another version” = 0.3.3, 0.3.4 has a patch to disable hover functionality 😞) and open help folder as workspace and hover any image link for instance inside Embed files.md.

Any ideas what’s changed?

Related issue: https://github.com/svsool/vscode-memo/issues/306

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 1
  • Comments: 18 (8 by maintainers)

Most upvoted comments

Thank you so much! You are the best! 🤩

Thanks @bpasero for a quick fix! 🚀