vscode: Git gutters don't show on filenames that have changed case
- VSCode Version: 1.47.3 91899dcef7b8110878ea59626991a18c8a6a1b3e
- OS Version: MacOS 10.14.6
Steps to Reproduce:
1. Initialize a git repository~
2. Add a capitalized filename, e.g. Counter.jsx
3. Commit the file
4. Make some changes in the file and save
The file will show as modified in the explorer, but the changes are not shown in the gutter. If you follow the same step but with a lowercase filename instead, the modifications will appear in the gutter. This is problematic for React projects where uppercase filenames are not uncommon.
Edit: See my modified instructions below
This issue was already brought up in #48714 and closed by 375411e, but the issue still occurs. I’m opening this new issue since the old one is locked.
Does this issue occur when all extensions are disabled?: Yes
About this issue
- Original URL
- State: open
- Created 4 years ago
- Reactions: 3
- Comments: 18 (10 by maintainers)
Commits related to this issue
- Rename 'htmlToMarkdown' -> 'toMarkdown' To fix bug on my VSCode: https://github.com/microsoft/vscode/issues/103444 — committed to EvitanRelta/markgh by EvitanRelta 2 years ago
- Capitalise the 'P' in 'preprocesses' & 'postprocesses' dir If VSCode's Git-gutters bugs out and stops working, apply this fix: https://github.com/microsoft/vscode/issues/103444#issuecomment-687071845 — committed to EvitanRelta/htmlarkdown by EvitanRelta 2 years ago
I’d just like to point out the bug also stretches to the built-in diff view. If you open that, select a range, right click and use “Stage selected ranges”, it gets staged in git as a new file that has the original casing, with the additions from the selected range as its only content.
While that original-case file is staged, the gutters do show up in the editor for the new-case file. Trying to stage something again in the diff view appends the additions from that range to the original-casing file.
It also creates an entry for the original-case file in the unstaged changes list. Viewing the diff of this shows it as the whole file being an addition, except for the range originally marked for staging.
Unstaging the original-case file in its entirety makes everything go back to the same state as before the first stage action, in which the file is shown only once in the changes window, and the gutters are not visible.
As suggested in https://github.com/microsoft/vscode/issues/103444#issuecomment-687071845, the bug stuck around if reloading while the file was open, but went away after closing all open file views and then reloading window.
Well, I guess the uri identity service won’t help you then because it doesn’t know what the actual representation is. If the git is so sensitive then I am afraid that you need to resolve the true casing before interacting with git.
Thanks @mattrossman, I can repro this on Windows as well. Sorry for not paying closer attention
@bpasero Here’s another tough pickle for you. These are the steps: https://github.com/microsoft/vscode/issues/103444#issuecomment-666541057
What happens is: once the workbench knows about
counter.jsx, it creates an editor model for it. When that file is renamed toCounter.jsx, and even after closing all text editors, upon opening theCounter.jsxtext editor, its model still holds a reference to a URI which lists the lowercase variant of the file. Here’s where SCM reads it and where this bug surfaces:https://github.com/microsoft/vscode/blob/56adc7d930ad862c90f82964bb3f618d342ba177/src/vs/workbench/contrib/scm/browser/dirtydiffDecorator.ts#L1179-L1179
The bug surfaces since git is case sensitive, despite Windows being case insensitive.
More notes:
I’m not sure what you want me to do, I’m not using a remote in my example so it’s not clear when I should be pushing or cloning. @Oran seems to be having a different issue from me since they did not change filenames.