vscode: Get stuck when searching in big text file
- VSCode Version:1.43.0
- OS Version:macbook pro 2018, os mojave
Steps to Reproduce:
1.a big text file about 11MB 2.search a string in this file, the software will get stuck about 10 seconds 3.In the previous versions, I didn’t find this problem.
Does this issue occur when all extensions are disabled?: No
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 18 (7 by maintainers)
Commits related to this issue
- Use a max length since we are inserting the whole msg in the DOM and that can cause browsers to freeze for long messages fixes #94233 — committed to relmify/vscode by isidorn 4 years ago
I can reproduce the issue with the file you attached. I have tuned the lenght to 20000, since on my machine it is pretty responsive for that length and I think that is long enough that no user would want to hear a message that long. If users complain we can always fine tune the number.
@alexdima sorry about this! As you suggest I think we can tackle this on the aria alert side, since no user will listen to 15mb of text being read out. Thus all alerts should have a cap before they are put in the DOM.