vscode: Extension Host terminated unexpectedly

Steps for verification:

1. Open helloworld extension in latest stable, add the following changes

diff --git a/helloworld-minimal-sample/extension.js b/helloworld-minimal-sample/extension.js
index 9b28fa2..424008b 100644
--- a/helloworld-minimal-sample/extension.js
+++ b/helloworld-minimal-sample/extension.js
@@ -1,9 +1,7 @@
 // The module 'vscode' contains the VS Code extensibility API
 // Import the module and reference it with the alias vscode in your code below
 const vscode = require('vscode');
-
-// this method is called when your extension is activated
-// your extension is activated the very first time the command is executed
+const { spawnSync } = require('node:child_process');

 /**
  * @param {vscode.ExtensionContext} context
@@ -21,6 +19,8 @@ function activate(context) {

                // Display a message box to the user
                vscode.window.showInformationMessage('Hello World!');
+               spawnSync('winget', ['--version']);
+               spawnSync('node', ['--version']);
        });

        context.subscriptions.push(disposable);

1. Debug extension, run hello world command
2. Stop the debug session
3. Start debug extension again, run hello world command
4. It should crash the extension host

Perform steps 1-4 again in latest insiders with the fix and it should not crash.

Thanks for sharing the fix @pfitzseb , I will backport the fix into Electron as next step.

Might be fixed by https://github.com/libuv/libuv/pull/4152.

Apparrently Julia expects 8 arguments. Not sure why though…

if length(Base.ARGS) != 8 error(“Invalid number of arguments passed to julia language server.”) end

PS C:\temp> node  -v
v18.15.0


PS C:\temp> node .\spawn_julia_ls.js
  Activating project at `c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\environments\languageserver\v1.9`
[ Info: Starting the Julia Language Server
┌ Error: Some Julia code in the VS Code extension crashed
└ @ Main c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\error_handler.jl:15
ERROR: Invalid number of arguments passed to julia language server.
Stacktrace:
 [1] error(s::String)
   @ Base .\error.jl:35
 [2] top-level scope
   @ c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\languageserver\main.jl:34
 [3] include(mod::Module, _path::String)
   @ Base .\Base.jl:457
 [4] exec_options(opts::Base.JLOptions)
   @ Base .\client.jl:307
 [5] _start()
   @ Base .\client.jl:522



PS C:\temp> node .\spawn_julia_ls.js
  Activating project at `c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\environments\languageserver\v1.9`
[ Info: Starting the Julia Language Server

Base.ARGS = ["c:\\Users\\bernhard.koenig\\Documents\\Repositories\\InfluxDBClient.jl", "--debug=no", "c:\\Users\\bernhard.koenig\\AppData\\Roaming\\Code\\User\\globalStorage\\julialang.language-julia", "download", "https://www.julia-vscode.org/symbolcache", "--detached=no"]

┌ Error: Some Julia code in the VS Code extension crashed
└ @ Main c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\error_handler.jl:15
ERROR: Invalid number of arguments passed to julia language server.
Stacktrace:
 [1] error(s::String)
   @ Base .\error.jl:35
 [2] top-level scope
   @ c:\Users\bernhard.koenig\.vscode\extensions\julialang.language-julia-1.51.2\scripts\languageserver\main.jl:35
 [3] include(mod::Module, _path::String)
   @ Base .\Base.jl:457
 [4] exec_options(opts::Base.JLOptions)
   @ Base .\client.jl:307
 [5] _start()
   @ Base .\client.jl:522
PS C:\temp>