vscode: Extension contributed submenus missing with errors in output

Does this issue occur when all extensions are disabled?: No

• VS Code Version: 1.70.0-insider
• OS Version: Darwin x64 21.5.0

VS Code version info

Version: 1.70.0-insider Commit: 052d5b0027f6c9d64c8ca35955cb5117ba94d5d7 Date: 2022-07-13T05:21:34.551Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Darwin x64 21.5.0

The Azure Resource Groups extension has a submenus that aren’t showing up on Insiders, but show up as expected on VS Code Stable. https://github.com/microsoft/vscode-azureresourcegroups/issues/330

The issue only reproduces on insiders 1.70.0-insider. Does not repro on stable (1.69.1)

I’ve verified that this bug impacts GitLens submenus as well, but haven’t had time to log the issue over there yet.

I’ve made a sample extension as a minimal reproduction. https://github.com/alexweininger/vscode-submenu-sample

Steps to Reproduce:

1. Open new window of VS Code Insiders (with a folder/files open if you want to verify that the sample submenu disappears)
2. Install Submenu sample extension VSIX of the sample extension I made that contributes a submenu to the editor/title.
3. View “Log (Window)” output channel. If there aren’t errors yet, disabling the submenu sample extension, which seems to reload all the extension contributions which causes the error.
4. After these errors are shown in the logs, the submenu disappears.

I believe it could be caused by 21147b8 (#154801)

Errors from the “Log (Window)” output channel:

[2022-07-13 00:16:54.982] [renderer7] [error] Duplicate menu identifier api:git.commit: Error: Duplicate menu identifier api:git.commit
    at new o (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:697:3734)
    at i._handler (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1691:42853)
    at i._handle (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1686:26570)
    at i.acceptUsers (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1686:26474)
    at Function._handleExtensionPoint (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3172:33062)
    at E._doHandleExtensionPoints (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3172:31895)
    at E._deltaExtensions (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3172:20709)
    at async E._handleDeltaExtensions (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3172:19726)
[2022-07-13 00:16:54.983] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.commit` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.984] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.changes` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.984] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.pullpush` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.984] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.branch` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.984] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.remotes` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.984] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.stash` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.985] [renderer7] [error] [vscode.git]: Menu item references a submenu `git.tags` which is not defined in the 'submenus' section.
[2022-07-13 00:16:54.985] [renderer7] [info] [vscode.git]: `git.commit` is not a valid menu identifier
[2022-07-13 00:16:54.985] [renderer7] [info] [vscode.git]: `git.changes` is not a valid menu identifier
[2022-07-13 00:16:54.985] [renderer7] [info] [vscode.git]: `git.pullpush` is not a valid menu identifier
[2022-07-13 00:16:54.985] [renderer7] [info] [vscode.git]: `git.branch` is not a valid menu identifier
[2022-07-13 00:16:54.986] [renderer7] [info] [vscode.git]: `git.remotes` is not a valid menu identifier
[2022-07-13 00:16:54.986] [renderer7] [info] [vscode.git]: `git.stash` is not a valid menu identifier
[2022-07-13 00:16:54.986] [renderer7] [info] [vscode.git]: `git.tags` is not a valid menu identifier
[2022-07-13 00:16:54.987] [renderer7] [info] [testing.helloworld-sample]: `foo` is not a valid menu identifier
[2022-07-13 00:16:54.987] [renderer7] [error] [testing.helloworld-sample]: Menu item references a submenu `foo` which is not defined in the 'submenus' section.

https://user-images.githubusercontent.com/12476526/178681189-53b164d9-4e84-4bcd-9156-61919cb67f55.mov

You can also easily reproduce this by installing and enabled/disabling various extensions that contribute submenus. Ex: GitLens and Azure Resource Groups.