vscode-eslint: "Running save participants" hangs indefinitely on VSCode 1.42.1

image (4)

VSCode Version: 1.42.1
ESLint Extension Version: 2.1.1
OS Version: Darwin x64 19.3.0

Steps to Reproduce:

I’m not completely sure where all of my configuration is, but this is my settings.json:

{
  "editor.tabSize": 2,

  "files.associations": {
    "*.css": "postcss"
 },
  "files.exclude": {
    "**/node_modules/**": true
  },
  "files.watcherExclude": {
    "**/dist/**": true
  },
  "search.exclude": {
    "**/dist/**": true
  },
  
  "typescript.tsdk": "node_modules/typescript/lib",

  "eslint.alwaysShowStatus": true,
  "eslint.packageManager": "yarn",
  "eslint.validate": [
    { "language": "javascript", "autoFix": true },
    { "language": "javascriptreact", "autoFix": true },
    { "language": "typescript", "autoFix": true },
    { "language": "typescriptreact", "autoFix": true }
  ],

  "prettier.disableLanguages": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact"
  ],

  "eslint.autoFixOnSave": true,
  "editor.formatOnSave": false,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },
}

and this is my prettier.config.js:

module.exports = {
  semi: false,
  singleQuote: true,
  jsxSingleQuote: true
}

I tried removing the deprecated "eslint.autoFixOnSave": true and there was no change.

This issue does not occur if I revert back to VSCode 1.41.1. It also does not occur if I disable the ESLint plugin on 1.42.1.

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 14
Comments: 30 (12 by maintainers)

Most upvoted comments

@AbelHu this sounds like a problem with the Go extension then and has nothing to do with ESLint.

dbaeumer on Mar 2, 2020

@dbaeumer Unfortunately my project is a private repository not even on Github, but let me see if I can reproduce it with a smaller project example today.

Polantaris on Mar 2, 2020

I’m also experiencing this on VSCode 1.42.1 with the latest eslint plugin. Unfortunately my repo is private and also very large, so I don’t really have any code to share, however my settings.json is below.

{
	"editor.insertSpaces": false,
	"editor.wordWrap": "on",
	"editor.formatOnSave": false,
	"[html]": {
		"editor.formatOnSave": true
	},
	"eslint.autoFixOnSave": true,
	"editor.formatOnPaste": true,
	"typescript.tsdk": "[private repo]/node_modules/typescript/lib",
	"html.format.wrapAttributes": "preserve-aligned",
	"html.format.wrapLineLength": 240,
	"eslint.validate": [
		"javascript",
		{
			"language": "typescript",
			"autoFix": true,
		}
	],
	"eslint.run": "onType",
	"eslint.trace.server": "messages",
	"eslint.workingDirectories": [
		{
			"directory": "[private repo]",
			"changeProcessCWD": true
		}
	],
	"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true,
	"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true,
	"editor.codeActionsOnSave": {
		"source.fixAll.eslint": true
	},
	"eslint.enable": true
}

I’m happy to try anything to fix it, I’ve had to disable the eslint plugin for now because every save can take an upwards of five minutes to complete, however that’s not a long term solution.

Polantaris on Feb 27, 2020

@katz12 the difference is that you will not see the dialog but the save participant will not run either in 1.41.1. So it would be really good if I would be able to reproduce this. Could I get access to the code in a non public way ?

dbaeumer on Feb 27, 2020