vscode: Error while formatting range for file HTML

Here’s a regression in some latest nightlies, it happens when formatting code. Formatting fails:

[Error - 1:18:06 PM] Error while formatting range for file:///<path edited out by issuer for security>.html: Ovelapping edit
Error: Ovelapping edit
    at Object.applyEdits (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/node_modules/vscode-languageserver-types/lib/umd/main.js:803:27)
    at Object.format (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/modes/formatting.js:75:72)
    at Object.<anonymous> (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:415:64)
    at step (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:36:23)
    at Object.next (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:17:53)
    at fulfilled (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:8:58)
    at <anonymous>
[Error - 1:18:06 PM] Error while formatting range for file:///<path edited out by issuer for security>.html: Ovelapping edit
Error: Ovelapping edit
    at Object.applyEdits (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/node_modules/vscode-languageserver-types/lib/umd/main.js:803:27)
    at Object.format (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/modes/formatting.js:75:72)
    at Object.<anonymous> (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:415:64)
    at step (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:36:23)
    at Object.next (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:17:53)
    at fulfilled (<vscn path edited out for security> /VSCode-linux-x64/resources/app/extensions/html-language-features/server/out/htmlServerMain.js:8:58)
    at <anonymous>

VSCode Version: code-insider-1.23.0-1523596516_amd64.tar.gz code-insider-1.23.0-1523942099_amd64.tar.gz
Platform Ubuntu 14.04 but I bet it’s irrelevant.

-R

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 16 (9 by maintainers)

Commits related to this issue

test for #48049 — committed to microsoft/vscode by aeschli 6 years ago

Most upvoted comments

Fixed pushed to vscode-languageserver-node.

aeschli on May 3, 2018

@aeschli I dont have any such settings and can repro this even with all extensions disabled.

I was able to find the root cause in the compare function passed to mergeSort when applying the edits. See

https://github.com/Microsoft/vscode-languageserver-node/blob/4c66383e92a2f7d513f93e5ecc74b21b4889d3a5/types/src/main.ts#L1602

We should be returning diff there not 0

ramya-rao-a on May 2, 2018