vscode: editor.smoothScrolling breaks find jump

Type: Bug

With editor.smoothScrolling enabled if I use find widget inside editor it doesn’t jump straight to the first match, it only scrolls a little bit, but if I press <kbd>Enter</kbd> again it jumps as expected to the second match and reveals text. Even though I see cursor moved it scrolled just a bit down. If I disable editor.smoothScrolling everything works fine as before. I feel like this is a regression and started to happen after 1.72 or 1.73.

As you can see from the gif it scrolls, but not enough, because foo is still invisible and if I hit <kbd>Enter</kbd> again it scrolled to the second match which revealed text I was looking for. And, if you take a look into scrollbar you will see that my cursor position was moved to the 1 match.

Recording 2023-02-05 at 22 23 26

VS Code version: Code 1.75.0 (e2816fe719a4026ffa1ee0189dc89bdfdbafb164, 2023-02-01T15:26:31.005Z) OS version: Darwin arm64 22.3.0 Modes: Sandboxed: No

System Info
Item Value
CPUs Apple M1 Pro (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 6, 6, 6
Memory (System) 32.00GB (0.95GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (17)
Extension Author (truncated) Version
vscode-eslint dba 2.2.6
gitlens eam 13.2.0
prettier-vscode esb 9.10.4
auto-rename-tag for 0.1.10
copilot Git 1.71.8269
vscode-graphql Gra 0.8.5
vscode-graphql-syntax Gra 1.0.6
fluent-icons mig 0.0.18
symbols mig 0.0.9
vscode-react-native msj 1.10.0
color-highlight nau 2.5.0
vscode-thunder-client ran 2.3.4
vscode-fileutils sle 3.10.0
highlight-matching-tag vin 0.10.1
vscodeintellicode Vis 1.2.30
vim vsc 1.24.3
quokka-vscode Wal 1.0.524

(1 theme extensions excluded)

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Reactions: 1
  • Comments: 18 (8 by maintainers)

Most upvoted comments

🎉 We were able to get reproducible steps and track down the root problem in https://github.com/microsoft/vscode/issues/179368#issuecomment-1499293621 . Let’s continue tracking in #179368, a PR with a fix is under way.

@alexdima I’m not even using vim and it’s happening for me. I think you closed this prematurely.