vscode: "Create new github issue notebook" fails

I do several iterations of randomly

Run “Create new github issue notebook”
Reload the window
Save it
Or run the create command and close it without saving

At some point, I get a notification that the command failed and see this error:

ERR NO notebook document for 'untitled:Untitled-1.github-issues?github-issues': Error: NO notebook document for 'untitled:Untitled-1.github-issues?github-issues'
at u.getNotebookDocument (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:84:202965)
at u.$acceptDirtyStateChanged (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:84:208771)
at d._doInvokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:88:12797)
at d._invokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:88:12489)
at d._receiveRequest (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:88:11145)
at d._receiveOneMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:88:9945)
at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:88:8049
at a.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57:1835)
at _.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:15632)
at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:29788
at a.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57:1835)
at _.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:15632)
at t._receiveMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:20890)
at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:17776
at a.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:57:1835)
at c.acceptChunk (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:12993)
at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:65:12341
at Socket.E (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:13267)
at Socket.emit (events.js:315:20)
at addChunk (internal/streams/readable.js:309:12)
at readableAddChunk (internal/streams/readable.js:284:9)
at Socket.Readable.push (internal/streams/readable.js:223:10)
at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

I have hit it a couple times. I can’t get good repro steps though.

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 44 (43 by maintainers)

Commits related to this issue

prevent reentrant resolving of editor inputs, https://github.com/microsoft/vscode/issues/125211 — committed to microsoft/vscode by jrieken 3 years ago
backups - only resolve editors that are not active (#125211) — committed to microsoft/vscode by bpasero 3 years ago
Revert "prevent reentrant resolving of editor inputs, https://github.com/microsoft/vscode/issues/125211" This reverts commit 62db4e23d4e744742368088284bb2bba804d4963. — committed to microsoft/vscode by jrieken 3 years ago
better re-entrant protection for https://github.com/microsoft/vscode/issues/125211 — committed to microsoft/vscode by jrieken 3 years ago
backup restorer - make sure to disable overrides (#125211) — committed to microsoft/vscode by bpasero 3 years ago
resolve working copy when load is called again, https://github.com/microsoft/vscode/issues/125211 — committed to microsoft/vscode by jrieken 3 years ago

Most upvoted comments

Pushed another change to ensure NotebookEditorInput#resolve is safe for re-entrant calls. The backup tracker and the editor tab restoring would happen at the same time (esp when things are slow) and than https://github.com/microsoft/vscode/issues/126853 would show.

jrieken on Jun 23, 2021

If I didn’t have a chat with Rob today I wouldn’t know there is already a discussion about how backup and historyService handles non-file editor inputs 😭 Spent a day on this and ended up with same findings:

rebornix on Jun 22, 2021