vscode: Can't start selfhost build

I can confirm it’s working also, thanks!

Should be fixed now after a debug session with @joaomoreno

Here’s my plan for this:

• Bring back terminal.integrated.inheritEnv, keep the default as true which will use the patched environment and false we will use the unpatched environment (instead of the solution which had a bunch of issues before).
• Add IShellLaunchConfig.inheritEnv?: boolean which will let tasks override whatever the setting is since they could break otherwise.
• For WSL (maybe other remotes) terminals we don’t run a login shell on start up, so things on $PATH may be missing in regular terminals when terminal.integrated.inheritEnv is set to false. This will be considered by design and it will be up to the user to run their terminal as a login shell if that’s desired, I’ll explain this in the terminal.integrated.inheritEnv config description.

@jasonwilliams I believe that build didn’t contain the fix yet. We just released another Insiders which contains the fix, my issue is gone:

Version: 1.57.0-insider (user setup)
Commit: 37a12c9b0846167b2f68e9e1f276149d2d8b9b27
Date: 2021-05-12T14:14:26.024Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19043

@jasonwilliams do you have any terminal settings set?

I still get this issue in today’s Insiders. Toggling terminal.integrated.inheritEnv makes no difference at all. 😢

Looks like a regression from the removal of shell env in renderer and/or shared process, does not reproduce when running from a terminal.