vscode: Calling reveal on a WebviewPanel inside a diff view incorrectly reveals the individual webview
Version: 1.54.1 (user setup) Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8 Date: 2021-03-04T22:38:31.419Z Electron: 11.3.0 Chrome: 87.0.4280.141 Node.js: 12.18.3 V8: 8.7.220.31-electron.0 OS: Windows_NT x64 10.0.19042
Steps to Reproduce:
- Install the Jupyter extension in VS Code stable.
- Ensure you are opted out of the Native Notebooks experiment in your settings (see below for setting value) and delete
workbench.editorAssociationsif it’s present in your user settings.json. This will force the Jupyter extension to use our custom editor implementation for displaying notebooks.
"jupyter.experiments.optOutFrom": [
"NativeNotebookEditor",
],
Verify it looks like this, and not the new native notebooks UI:
- Create and save an ipynb file in a local git repo.
- From the source control view open the ipynb file. It will open in the custom editor, preventing users from viewing the notebook diff.
Does this issue occur when all extensions are disabled?: No
/cc @ianmatthewhuff @greazer @rchiodo @davidkutu @DonJayamanne
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 1
- Comments: 22 (18 by maintainers)
Commits related to this issue
- Avoid calling `reveal` if a webview is already active or visible For https://github.com/microsoft/vscode/issues/118764 — committed to mjbvz/vscode-jupyter by mjbvz 3 years ago
- Avoid calling `reveal` if a webview is already active or visible (#5276) For https://github.com/microsoft/vscode/issues/118764 — committed to microsoft/vscode-jupyter by mjbvz 3 years ago
- Avoid calling `reveal` if a webview is already active or visible (#5276) For https://github.com/microsoft/vscode/issues/118764 — committed to microsoft/vscode-jupyter by mjbvz 3 years ago
Jupyter PR is up: https://github.com/microsoft/vscode-jupyter/pull/5276
I can confirm that I’m now getting rich editors on the left and right using v2021.5.702919634. I don’t like it, since it doesn’t highlight differences or synchronize scrolling in the two panes (i.e. it’s not a good diff view), but it is at least a diff view, so I think this issue is fixed.
@joyceerhl I can confirm the bug is fixed. Thanks for all the help!