TypeScript: tsc -w does not correctly compile file imports

When running tsc -w, the compiler is incorrectly removing certain module imports. It would appear this bug happens when the imported module’s only usage is in a promise. If used outside of the promise, the compiler does import the file correctly. This only happens when running the compiler in watch mode.

TypeScript Version: 2.7.0-dev.201xxxxx

Search Terms: tsc tsc-w import missing promise

Code

import * as MyService from '../service/MyService';
export function find() {
  return new Promise((resolve, reject) => {
        MyService.find()  
  })
}

Expected tsc output:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const MyService = require("../service/MyService");
function find() {
    return new Promise((resolve, reject) => {
            MyService.findNext();
    });
}
exports.find = find;

Actual tsc output:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
function find() {
    return new Promise((resolve, reject) => {
            MyService.findNext();
    });
}
exports.find = find;

Playground Link: Cant really replicate here because I can’t import from disk

Related Issues: none that I’ve found

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 7
  • Comments: 22 (21 by maintainers)

Most upvoted comments

Also encountered this in TS@2.7.1

First pass is compiled correctly. Second pass is missing some imports.

This is the source file: https://github.com/unional/komondor/blob/ts-2.7-compile-error/src/spec.ts

In first pass, line 45-52:

Object.defineProperty(exports, "__esModule", { value: true });
var assertron_1 = require("assertron");
var tersify_1 = require("tersify");
var unpartial_1 = require("unpartial");
var io_1 = require("./io");
var SpecOptions_1 = require("./SpecOptions");
var specStore_1 = require("./specStore");
var plugin_1 = require("./plugin");

Second pass (after making some change elsewhere):

Object.defineProperty(exports, "__esModule", { value: true });
var assertron_1 = require("assertron");
var tersify_1 = require("tersify");
var io_1 = require("./io");
var specStore_1 = require("./specStore");
var plugin_1 = require("./plugin");

First pass full content:

"use strict";
var __assign = (this && this.__assign) || Object.assign || function(t) {
    for (var s, i = 1, n = arguments.length; i < n; i++) {
        s = arguments[i];
        for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
            t[p] = s[p];
    }
    return t;
};
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
    return new (P || (P = Promise))(function (resolve, reject) {
        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
        function step(result) { result.done ? resolve(result.value) : new P(function (resolve) { resolve(result.value); }).then(fulfilled, rejected); }
        step((generator = generator.apply(thisArg, _arguments || [])).next());
    });
};
var __generator = (this && this.__generator) || function (thisArg, body) {
    var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g;
    return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
    function verb(n) { return function (v) { return step([n, v]); }; }
    function step(op) {
        if (f) throw new TypeError("Generator is already executing.");
        while (_) try {
            if (f = 1, y && (t = y[op[0] & 2 ? "return" : op[0] ? "throw" : "next"]) && !(t = t.call(y, op[1])).done) return t;
            if (y = 0, t) op = [0, t.value];
            switch (op[0]) {
                case 0: case 1: t = op; break;
                case 4: _.label++; return { value: op[1], done: false };
                case 5: _.label++; y = op[1]; op = [0]; continue;
                case 7: op = _.ops.pop(); _.trys.pop(); continue;
                default:
                    if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; }
                    if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; }
                    if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; }
                    if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; }
                    if (t[2]) _.ops.pop();
                    _.trys.pop(); continue;
            }
            op = body.call(thisArg, _);
        } catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; }
        if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true };
    }
};
Object.defineProperty(exports, "__esModule", { value: true });
var assertron_1 = require("assertron");
var tersify_1 = require("tersify");
var unpartial_1 = require("unpartial");
var io_1 = require("./io");
var SpecOptions_1 = require("./SpecOptions");
var specStore_1 = require("./specStore");
var plugin_1 = require("./plugin");
function makeErrorSerializable(actions) {
    actions.forEach(function (a) {
        if (isRejectErrorPromiseReturnAction(a) ||
            isErrorThrowAction(a)) {
            a.payload = __assign({ message: a.payload.message }, a.payload);
        }
    });
}
exports.makeErrorSerializable = makeErrorSerializable;
function isErrorThrowAction(action) {
    return /\/throw/.test(action.type) && action.payload instanceof Error;
}
function isRejectErrorPromiseReturnAction(action) {
    return action.type === 'promise' && action.meta.status === 'reject' && action.payload instanceof Error;
}
exports.spec = Object.assign(function spec(id, subject) {
    return __awaiter(this, void 0, void 0, function () {
        var opt, mode;
        return __generator(this, function (_a) {
            opt = unpartial_1.unpartial(SpecOptions_1.defaultSpecOptions, { id: id, mode: 'verify' });
            mode = SpecOptions_1.getMode(opt);
            return [2 /*return*/, createSpec(opt.id, subject, mode)];
        });
    });
}, {
    save: function (id, subject) {
        return __awaiter(this, void 0, void 0, function () {
            var mode;
            return __generator(this, function (_a) {
                mode = SpecOptions_1.getMode({ id: id, mode: 'save' });
                return [2 /*return*/, createSpec(id, subject, mode)];
            });
        });
    },
    simulate: function (id, subject) {
        return __awaiter(this, void 0, void 0, function () {
            var mode;
            return __generator(this, function (_a) {
                mode = SpecOptions_1.getMode({ id: id, mode: 'simulate' });
                return [2 /*return*/, createSpec(id, subject, mode)];
            });
        });
    }
});
function createSpec(id, subject, mode) {
    return __awaiter(this, void 0, void 0, function () {
        var store, context;
        return __generator(this, function (_a) {
            switch (_a.label) {
                case 0:
                    store = specStore_1.createSpecStore();
                    context = store;
                    context.mode = mode;
                    context.id = id;
                    if (!(mode === 'simulate')) return [3 /*break*/, 2];
                    return [4 /*yield*/, store.load(id)];
                case 1:
                    _a.sent();
                    context.subject = plugin_1.komondorUtil.getStub(context, subject, id);
                    return [3 /*break*/, 3];
                case 2:
                    context.subject = plugin_1.komondorUtil.getSpy(context, subject);
                    _a.label = 3;
                case 3: return [2 /*return*/, Object.assign(context, {
                        satisfy: function (expectation) {
                            return Promise.resolve().then(function () {
                                var actions = store.actions;
                                assertron_1.satisfy(actions, expectation);
                                if (mode === 'save') {
                                    // istanbul ignore next
                                    if (!id)
                                        throw new Error('Cannot save spec without options.id.');
                                    makeErrorSerializable(actions);
                                    return io_1.io.writeSpec(id, {
                                        expectation: tersify_1.tersify(expectation, { maxLength: Infinity, raw: true }),
                                        actions: actions
                                    });
                                }
                            });
                        }
                    })];
            }
        });
    });
}
//# sourceMappingURL=spec.js.map

Second pass full content:

"use strict";
var __assign = (this && this.__assign) || Object.assign || function(t) {
    for (var s, i = 1, n = arguments.length; i < n; i++) {
        s = arguments[i];
        for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
            t[p] = s[p];
    }
    return t;
};
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
    return new (P || (P = Promise))(function (resolve, reject) {
        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
        function step(result) { result.done ? resolve(result.value) : new P(function (resolve) { resolve(result.value); }).then(fulfilled, rejected); }
        step((generator = generator.apply(thisArg, _arguments || [])).next());
    });
};
var __generator = (this && this.__generator) || function (thisArg, body) {
    var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g;
    return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
    function verb(n) { return function (v) { return step([n, v]); }; }
    function step(op) {
        if (f) throw new TypeError("Generator is already executing.");
        while (_) try {
            if (f = 1, y && (t = y[op[0] & 2 ? "return" : op[0] ? "throw" : "next"]) && !(t = t.call(y, op[1])).done) return t;
            if (y = 0, t) op = [0, t.value];
            switch (op[0]) {
                case 0: case 1: t = op; break;
                case 4: _.label++; return { value: op[1], done: false };
                case 5: _.label++; y = op[1]; op = [0]; continue;
                case 7: op = _.ops.pop(); _.trys.pop(); continue;
                default:
                    if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; }
                    if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; }
                    if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; }
                    if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; }
                    if (t[2]) _.ops.pop();
                    _.trys.pop(); continue;
            }
            op = body.call(thisArg, _);
        } catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; }
        if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true };
    }
};
Object.defineProperty(exports, "__esModule", { value: true });
var assertron_1 = require("assertron");
var tersify_1 = require("tersify");
var io_1 = require("./io");
var specStore_1 = require("./specStore");
var plugin_1 = require("./plugin");
function makeErrorSerializable(actions) {
    actions.forEach(function (a) {
        if (isRejectErrorPromiseReturnAction(a) ||
            isErrorThrowAction(a)) {
            a.payload = __assign({ message: a.payload.message }, a.payload);
        }
    });
}
exports.makeErrorSerializable = makeErrorSerializable;
function isErrorThrowAction(action) {
    return /\/throw/.test(action.type) && action.payload instanceof Error;
}
function isRejectErrorPromiseReturnAction(action) {
    return action.type === 'promise' && action.meta.status === 'reject' && action.payload instanceof Error;
}
exports.spec = Object.assign(function spec(id, subject) {
    return __awaiter(this, void 0, void 0, function () {
        var opt, mode;
        return __generator(this, function (_a) {
            opt = unpartial_1.unpartial(SpecOptions_1.defaultSpecOptions, { id: id, mode: 'verify' });
            mode = SpecOptions_1.getMode(opt);
            return [2 /*return*/, createSpec(opt.id, subject, mode)];
        });
    });
}, {
    save: function (id, subject) {
        return __awaiter(this, void 0, void 0, function () {
            var mode;
            return __generator(this, function (_a) {
                mode = SpecOptions_1.getMode({ id: id, mode: 'save' });
                return [2 /*return*/, createSpec(id, subject, mode)];
            });
        });
    },
    simulate: function (id, subject) {
        return __awaiter(this, void 0, void 0, function () {
            var mode;
            return __generator(this, function (_a) {
                mode = SpecOptions_1.getMode({ id: id, mode: 'simulate' });
                return [2 /*return*/, createSpec(id, subject, mode)];
            });
        });
    }
});
function createSpec(id, subject, mode) {
    return __awaiter(this, void 0, void 0, function () {
        var store, context;
        return __generator(this, function (_a) {
            switch (_a.label) {
                case 0:
                    store = specStore_1.createSpecStore();
                    context = store;
                    context.mode = mode;
                    context.id = id;
                    if (!(mode === 'simulate')) return [3 /*break*/, 2];
                    return [4 /*yield*/, store.load(id)];
                case 1:
                    _a.sent();
                    context.subject = plugin_1.komondorUtil.getStub(context, subject, id);
                    return [3 /*break*/, 3];
                case 2:
                    context.subject = plugin_1.komondorUtil.getSpy(context, subject);
                    _a.label = 3;
                case 3: return [2 /*return*/, Object.assign(context, {
                        satisfy: function (expectation) {
                            return Promise.resolve().then(function () {
                                var actions = store.actions;
                                assertron_1.satisfy(actions, expectation);
                                if (mode === 'save') {
                                    // istanbul ignore next
                                    if (!id)
                                        throw new Error('Cannot save spec without options.id.');
                                    makeErrorSerializable(actions);
                                    return io_1.io.writeSpec(id, {
                                        expectation: tersify_1.tersify(expectation, { maxLength: Infinity, raw: true }),
                                        actions: actions
                                    });
                                }
                            });
                        }
                    })];
            }
        });
    });
}
//# sourceMappingURL=spec.js.map
+1
unional on Feb 4, 2018
Read more comments on GitHub
← TypeScript: tsc -b incorrectly succeeds when there is a problem introduced by a transitive dependency
TypeScript: tsc -w should not recompile if a file is created into an excluded folder →