TypeScript: NodeNext resolution failed to resolve dual-package correctly
Bug Report
NodeNext resolution failed to resolve dual-package correctly
🔎 Search Terms
NodeNext
🕗 Version & Regression Information
- Never worked
💻 Code
https://github.com/Jack-Works/ts-nodenext-wrong-resolution-reproduction
where node_modules/testpkg/package.json is
{
"name": "testpkg",
"exports": {
".": {
"types": "./dist/type.d.ts",
"require": "./dist/common.cjs",
"import": "./dist/module.mjs"
}
}
}
TypeScript should resolve type.d.ts in dual mode instead of CommonJS synthetic export.
🙁 Actual behavior
src/index.ts:2:1 - error TS2349: This expression is not callable.
Type 'typeof import("testpkg/dist/type")' has no call signatures.
🙂 Expected behavior
No error
About this issue
- Original URL
- State: open
- Created 2 years ago
- Reactions: 10
- Comments: 23 (12 by maintainers)
To add to the dialog:
It took ages to find this solution in order to get dual package exports working properly for TypeScript, but this solution by @Jack-Works works for us 🎉 (with some “gotchas” mentioned below).
Our package.json for our ESM “library” looks like:
Then, we are able to have our CJS “consumer” use this ESM “library” with the following
tsconfig.json:Here is the kicker: Simply copying the
*.d.tsfile and renaming it to*.d.ctsas mentioned by @Jack-Works was not sufficient for our case. This is because our “library” is an ESM package with relative path references, e.g.:When
foo.tsis compiled with TypeScript (and emits declarations), thefoo.d.tsfile (and the copiedfoo.d.ctsfile) will look identical. Then, when our CJS “package” tries to compile our “library” using TypeScript, it sees the.jsextension and is not clever enough to treat it as CommonJS. It results in the following error:The fix: rewrite all
.jsextensions inimportandexportreferences in our*.d.ctsfiles to instead be.cjs. That means we have a script that runs after build that looks like this:This feels very hacky and we would absolutely like to ditch this completely - but it seems to be the only way to achieve the following:
We would ❤️ to see more native support that doesn’t require so much juggling.
I am one of the maintainers of a “dual-package” and after reading this thread I have some questions related to the thread comments:
More detailed below:
The package in question is declared as ES Module (the
typeproperty is set tomodulein the package manifest file). The package doesn’t have main entry points per se and is structured as follows:In this case, both the CJS and the ESM implementation expose the exact same API (actually the CJS implementation is transpiled from the ESM one via Rollup inside a compiler).
That’s how the exports look like for each implementation:
That’s how the type declaration looks like:
And that’s how we configured the
exportsmap in the package manifest:As soon as TS 4.8 has been released I tried to switch
moduleResolutiontoNodeNextbut it seems like I am hitting issues due to the fact that I am only using one declaration file if my understanding is correct. So basically, the format of my export map is wrong and I should opt for something close to what @DanielRosenwasser suggested.I am also asking as the type declaration is being generated from our compiler and I will have to think about how we can generate one for CJS if we have to.
For instance, while trying to use the package in a project that uses CommonJS I am getting the following error from
tsserver:Thanks in advance for your input.
People are writing the wrong package.json again and again in the wild. Example: https://github.com/react-hook-form/resolvers/issues/460 I really think this is a problem the TS team should take care of if TS is really serious about fixing the ecosystem.
Thx for your answers @weswigham and @Jack-Works. I think my confusion come from the latest code snippet from this page of the handbook: https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing
Which seems to contradict what is being discussed here. Should the documentation be updated?
That makes sense, thanks a lot for all the very useful information, I can see what I should be doing now!
You can’t generally assume that an import in an ESM file will resolve the same when you convert that file to a CJS context. This is by design, of course; you’re taking advantage of conditional exports yourself. If you leave the imports untouched, TypeScript will resolve them “correctly,” but will it resolve to the same thing as it did in an ESM context? If not, will the import syntax used be appropriate for the different module it resolves to? Will the resulting file type check and do what you expect? You have to answer these questions yourself for every individual import.
All module resolution is in
moduleNameResolver.ts.