TypeScript: [NewErrors] 5.5.0-dev.20240414 vs 5.4.5

The following errors were reported by 5.5.0-dev.20240414, but not by 5.4.5 Pipeline that generated this bug Logs for the pipeline run File that generated the pipeline

This run considered 800 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 499 of 800 visited repos

Outcome	Count
Detected interesting changes	26
Detected no interesting changes	473
Git clone failed	6
Package install failed	85
Project-graph error in old TS	9
Too many errors in old TS	192
Unknown failure	9

Investigation Status

Repo	Errors	Outcome
adobe/react-spectrum	1	#56902
aidenybai/million	1	#56902
alangpierce/sucrase	2	#57847 + 9998 = new error
ardatan/graphql-tools	1	`suppressImplicitAnyIndexErrors` removed
ariakit/ariakit	4	`ts-expect-error` on a bug 😎
bitwarden/clients	2	predicate inference broke class subtyping
Chocobozzz/PeerTube	1	#57847, appears to be bug in the project code (?)
conventional-changelog/conventional-changelog	1	#57549, exact details unclear so far
framer/motion	1	#57847 detects an implicit coercion that was previously unnoticed
growthbook/growthbook	1	#57847 caused an `any` to now be narrowed to `Function`
heyxyz/hey	5
highcharts/highcharts	6	`keyofStringsOnly` removed
ionic-team/stencil	1	Predicate inference identifies likely bug
jupyterlab/jupyterlab	2	#57681 (don’t emit reference directives)
keplergl/kepler.gl	1	Doesn’t build on Windows. Likely #57681
LokerL/tts-vue	1	`suppressImplicitAnyIndexErrors` removed
microsoft/playwright	1	This monorepo isn’t building in 5.4, skipping
microsoft/vscode	1	vscode team will investigate
misskey-dev/misskey	4	predicate inference broke subtyping
outline/outline	1	`suppressImplicitAnyIndexErrors` removed
sequelize/sequelize	1	Unused `ts-expect-error`, seems good
strapi/strapi	12	Monorepo failed to build in 5.4, skipping
t3-oss/create-t3-app	1	`importsNotUsedAsValues` removed
tailwindlabs/headlessui	3
TanStack/router	2	Monorepo doesn’t build in 5.4, skipping
tweenjs/tween.js	1	`importsNotUsedAsValues` removed

About this issue

Original URL
State: open
Created 3 months ago
Comments: 30 (4 by maintainers)

Most upvoted comments

bitwarden/clients has this setup

  // Base class
  protected filterProvider(type: TwoFactorProviderType) {
    return type !== TwoFactorProviderType.OrganizationDuo;
  }

  // Derived class
  protected filterProvider(type: TwoFactorProviderType) {
    return type === TwoFactorProviderType.OrganizationDuo;
  }

So type predicate inference broke the class subtyping. They just need to add ): boolean to the base class method. FYi @willmartian @shane-melton @mgibson1

RyanCavanaugh on Apr 18, 2024