terminal: `[O` erroneously inputted after exiting from Neovim 0.7.0 in latest Terminal Preview
Windows Terminal version
1.14.1451.0
Windows build number
10.0.19044.1706
Other Software
Neovim 0.7.0 (https://github.com/neovim/neovim/releases/tag/v0.7.0)
Steps to reproduce
- Install Neovim
- Open it by running
nvimin your shell (works both incmdandpwsh) - exit it (
:q)
Expected Behavior
Neovim exits, nothing else happens.
Actual Behavior
Neovim exits, and the shell receives [O on its console input.
My guess would be that the characters are part of a response to some VT escape code from Neovim, but for some reason they get written separately and the shell gets them instead of Neovim.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 2
- Comments: 18 (10 by maintainers)
Commits related to this issue
- Filter focus events that came from the API (#13260) As described in #13238. libuv sends a focus event to jiggle the handle. Now that we support focus events as VT input (#12900), we'd translate those... — committed to microsoft/terminal by zadjii-msft 2 years ago
- Filter focus events that came from the API (#13260) As described in #13238. libuv sends a focus event to jiggle the handle. Now that we support focus events as VT input (#12900), we'd translate those... — committed to microsoft/terminal by zadjii-msft 2 years ago
- Properly filter focus events from the console API (#15606) This is an improved fix for #13238. Instead of handling focus events in the `TerminalInput::HandleKey` function and the need to filter them... — committed to microsoft/terminal by lhecker a year ago
Filed https://github.com/neovim/neovim/issues/18899 for investigation.
Theoretically, we might be able to route input in such a way that focus events from the API don’t hit this path. Ultimately, I am curious why this is being sent in the first place. That might affect the route we want to go in mitigating this.
It looks like there was an issue open on Neovim for something similar: neovim/neovim#17985 That says a fix has been merged in but trying the latest Neovim nightly still has the issue for me in Terminal, so it may not be related.