terminal: Clicking the current tab to raise the window should focus the text area
Environment
Windows build number: 10.0.18363.0
Windows Terminal version: 0.6.2951.0
Any other software? Nope
Steps to reproduce
- Start Terminal
- Focus another window
- Re-focus Terminal by clicking on the active tab
- Enter text using your keyboard
Expected behavior
Raising the Terminal window should focus the text area no matter how you do it.
Works as expected if you click any other tab than the currently active.
Actual behavior
Text input is ignored even though the Terminal window has focus. Text input is restored when clicking the text area or focusing another tab.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 28
- Comments: 22 (7 by maintainers)
Commits related to this issue
- In specific scenarios, focus the active control (#10048) A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That... — committed to microsoft/terminal by zadjii-msft 3 years ago
- In specific scenarios, focus the active control (#10048) A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That... — committed to microsoft/terminal by zadjii-msft 3 years ago
- In specific scenarios, focus the active control (#10048) A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That... — committed to microsoft/terminal by zadjii-msft 3 years ago
- In specific scenarios, focus the active control (#10048) A redo of #6290. That PR was overkill. In that one, we'd toss focus back to the active control any time that the tab view item got focus. That... — committed to microsoft/terminal by zadjii-msft 3 years ago
A bit sad this is still not fixed in 0.10.781.0 😥
This is not fixed in 0.7.3291.0
Luckily this is not too hard to work around. I tried a few things out, so besides clicking in the terminal window area one can hit tab 2 times or click a different tab and back to the tab you want. But yeah, I’ve sent a few words off into the ether after clicking a tab. LOL
I suppose some other possibilities until this can get fixed without breaking things is to show that the tab UI has focus (you can see focus shown if you hit left or right arrow key when the tab has focus) and/or flash when the tab UI has focus and you type. Or perhaps when certain keys, like say alpha/numeric are hit the focus moves to the terminal and text gets sent there.
What is odd is that Ctrl+Tab cycling around through the tabs or back again with Ctrl+Shift+Tab gives the window the proper focus when is back to that tab.
And I agree, getting focus right is very hard. I spent several years of my working career at MS in my past working on testing UI controls. 😃
@FaffeF https://github.com/microsoft/terminal/pull/6290#issuecomment-674189421