fluentui-blazor: fix: Visual Studio 2022 freezes and then crashes with v3-RC-1
š Bug Report
After updating the NuGet packages from v2.4.2 to v3.0.0-RC-1 on a .Net 8 Preview 7 Blazor project, Visual Studio 2022 v17.8.0 Preview 1.0 freezes and then crashes within a couple of minutes while trying to edit a razor file.
š» Repro or Code Sample
Note: The following should provide a way for you to reproduce the issue, but the issue manifests itself without doing these things eitherā¦ it just takes a little longer to crash. I feel like the issue has to do with the Icons package somehow.
- Clone the repo here: https://github.com/StevenRasmussen/FluentUIBlazorIssue
- Open the solution
- Open the
Index.razorfile - Try āGoing to definitionā on the
Deleteicon name or theIconparameter of theFluentIconcomponent on line 9. - Then move your cursor back and forth between those two and hover over them to get the tooltip to show. Usually within performing this 4-5 times, VS will freeze and crash. Hereās a video of it:
š¤ Expected Behavior
VS does not freeze and crash
š Your Environment
Windows 10 - Latest updates installed VS 2022 v17.8.0 Preview 1.0 .Net 8.0.100-preview.7 Microsoft.Fast.Components.FluentUI v3.0.0-rc-1 Microsoft.Fast.Components.FluentUI.Icons v3.0.0-rc-1
About this issue
- Original URL
- State: closed
- Created 10 months ago
- Comments: 30 (1 by maintainers)
It does not crash anymore when F12 or āGo To Definitionā on my side. Thanks guys!
@vnbaaij - I can confirm that this DOES NOT only happen when you
F12or āGo To Definitionā. I spent the day yesterday upgrading from v2 in one of my projects and never used the āGo To Definitionā but VS consistently crashed about every minute. This is due to the fact that the largest breaking change is with regards to howIconsare handled now. Everywhere you useFluentIconyou have to change the old propertyNametoIcon. This is where I believe VS struggles and will be a HUGE pain point for anyone when they go to upgrade. I had to kill VS in Task Manager (because I was impatient and did not want to wait for it to crash) every time I upgraded a component that had anyFluentIcons that needed changing. It was a race to try and get as many of them updated in a razor page until VS would crash (usually within 20 seconds).If youāre not going to do anything any time soon with regards to this design, then I would highly suggest you put a large banner on the āUpgradeā page saying that Visual Studio WILL crash multiple times if you have any occurrences of
FluentIconthat need to be upgraded.The good news is that now that my project is upgraded it has finally become āstableā and I havenāt experienced a crash since.
On a side noteā¦ I donāt feel like this ticket should be closed since the issue is clearly not fixed.
Iām trying to get the Visual Studio team involved on this.
Finally, I can confirm it no longer freezes or crashes the Visual Studio with v3.0.1
No, we have the issue I just linked too. This is the code that is called from VS. That is where the problem is.
As said before, I already involved the VS team. In fact we even pinpointed where exactly the problem occurs. See https://github.com/icsharpcode/ILSpy/issues/3075. Donāt know when this will be implemented in a VS release. We are trying to get a workaround/different solution in place. Also, no ETA on that.
For now, I would advise to try to go to the latest VS version. Or even preview (as you can have multiple versions of VS installed side by side). According to earlier reports shared here less problems seem to arise then
I received some pointers/steps to investigate from my internal contact. Will take a look tonight to see if we can find the culpritā¦
Facing same issue with .Net 7 and Fluent Blazor v3 Stable on Visual Studio 17.7.2 Latest Stable
@vnbaaij Anything on this? itās really getting on our way on using v3