jasmine-node: v1.14/v1.15 includes a breaking change in a minor version.

v1.14 works on node < 4; v1.15 does not. This is a major change.

Please revert and publish a v1.15 patch; and if you’d like to drop node < 4, please republish as a v2.

See https://travis-ci.org/es-shims/es5-shim/jobs/423131852 for an example.

EDIT by @brodybits: the breaking change is in 7ad50c84f46fd8b67ac0695c1c1f9b940aa11c94:

--- a/package.json
+++ b/package.json
@@ -25,7 +25,7 @@
   "dependencies": {
     "coffee-script": ">=1.0.1",
     "jasmine-reporters": "~1.0.0",
-    "jasmine-growl-reporter": "~0.0.2",
+    "jasmine-growl-reporter": "~1.0.1",
     "requirejs": ">=0.27.1",
     "walkdir": ">= 0.0.1",
     "underscore": ">= 1.3.1",

See below and https://github.com/es-shims/es5-shim/commit/5a27afb050b333f6b0f6b8f7e93dbf4a66c4a7d7 for explanation.

Second possibly breaking change was the following (already fixed now):

   "dependencies": {
-    "coffee-script": ">=1.0.1",
+    "coffeescript": ">=1.0.1",
     "jasmine-reporters": "~1.0.0"

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 1
Comments: 16

Commits related to this issue

[Tests] pin jasmine-node to v1.14, due to breaking change in minor version: https://github.com/mhevery/jasmine-node/issues/433 — committed to es-shims/es5-shim by ljharb 6 years ago
Use coffeescript@1 (quick fix) to avoid possibly breaking change in minor release (version 1.15.1) Ref: #433 — committed to brodybits/jasmine-node by deleted user 6 years ago
Use coffeescript@1 (quick fix) to avoid potentially breaking change in a minor release (version 1.15.1) Ref: #433 — committed to brodybits/jasmine-node by deleted user 6 years ago
Use coffeescript@1 (quick fix) to avoid potentially breaking change in a minor release and mark version 1.15.1 ref: #433 — committed to brodybits/jasmine-node by deleted user 6 years ago
[Tests] pin jasmine-node to ~1.13 jasmine-node v1.14+ depends on ~1.0.1 of jasmine-growl-reporter: https://github.com/mhevery/jasmine-node/issues/433 jasmine-growl-reporter v1.0.1 depends on growl ^1... — committed to es-shims/es5-shim by ljharb 6 years ago
Back to jasmine-growl-reporter@~0.2.0 needed by Node.js pre-4.0 ref: #433 — committed to mhevery/jasmine-node by deleted user 6 years ago
Back to jasmine-growl-reporter@~0.2.0 needed by Node.js pre-4.0 ref: #433 — committed to mhevery/jasmine-node by deleted user 6 years ago

Most upvoted comments

Thanks; the issue is indeed fixed https://travis-ci.org/es-shims/es5-shim/builds/424538191

Much obliged!!

ljharb on Sep 4, 2018

Let’s keep it here. You were right: evidence of the root problem was already given in the description.

I think part of the confusion was that the breaking change in 7ad50c8 was in 1.14.6, which was not marked so clearly, and caused the trouble in https://github.com/es-shims/es5-shim/commit/37e7f3ebca4c42296adf9e753c3a956dd8c84fae.

brodybits on Sep 4, 2018

node lib/jasmine-node/cli.js --growl spec mostly passes on Node.js 4.0, 0.12, and 0.10 if I checkout version 1.14.5.

It does not work on Node.js ~~4.0~~ 0.12 if I use version 1.16.0. Patch fix should be coming today.

brodybits on Sep 4, 2018

I would also like to see a quick, easy-to-read description of npm semver etiquette that we can point people to, to help avoid this kind of issue in the future. I just raised the request in semver/semver#461.

brodybits on Sep 4, 2018

Thanks, since it was the same root problem I figured I’d post it here; i’m happy to file a new one if you like.

ljharb on Sep 4, 2018

I just published version 1.6.0 which uses coffeescript@1, fixes some other dependencies to avoid major package updates, and adds a note that this package is in maintenance mode. Best of luck to @ljharb in solving the problem with es5-shim for good. Closing now.

brodybits on Aug 31, 2018

Thanks for the update. From https://github.com/mhevery/jasmine-node/compare/1.14.x...master the only breaking change I can see is in package.json:

   "dependencies": {
-    "coffee-script": ">=1.0.1",
+    "coffeescript": ">=1.0.1",
     "jasmine-reporters": "~1.0.0"

which has the same effect as using coffeescript@2 (until they publish another major release). Now labeled as a bug, hope to publish an update sometime next week.

As a side point I would rather fix this one thing than revert the whole change in 7aa3b531edef2aa870cf88fb61251ccab0c63351. Less messy in the history (IMHO). Another side point is that there is already a “v2” branch (https://github.com/mhevery/jasmine-node/tree/Jasmine2.0) that seems to both have new features and be outdated.

brodybits on Aug 31, 2018