codelyzer: Drop rules which produce warnings that are supposed to be compile-time errors

Drop:

  • templates-use-public
  • no-access-missing-member
  • invoke-injectable

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 16 (2 by maintainers)

Commits related to this issue

Most upvoted comments

I really don’t understand this choice. I use ng serve without the --aot flag because I want my dev environment to be as fast as possible and JIT compilation is made to achieve this purpose. During development I also want to be informed as soon as possible if I’m writing code that won’t work in production, when I will run ng build --prod. I don’t want to find it out once I think I’m done but I’m actually not because I have to run ng serve --aot and then refactor the code I thought would work. Am I missing something? I think this is a quite common use case.

No, of course. Codelyzer delegates this task to the compiler (with AOT mode) => ng build --prod

Because the Angular Language Service already checks that

  1. I know. Luckily for me, I use VSCode. Not everyone does though.
  2. I don’t unless I edit the html file. Unluckily for me, I use VSCode.
  3. That’s my point. I should not use the CI for this. Everything should fail fast. This is something I want to know as I type, at most before committing/pushing. I don’t want to find it out when I already implemented everything, pushed it to master and switched to another task.