meshery.io: Youtube video does not stop after modal has been closed.
Description
We have a youtube video embedded in a modal on this page. We can see the modal and hence youtube video after clicking on the button find video and slides here
. When we start the video and then close the modal either by clicking outside or by clicking on the close symbol on the top right the video does not stop and keeps going.
Expected Behavior The video should stop after we close the modal.
Screenshots
Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master
branch.
- See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
- See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 48 (33 by maintainers)
Hi @Susmita-Dey Imposter syndrome can be the biggest challenge even after learning something. You can refer to https://www.w3schools.com and https://developer.mozilla.org/en-US/ for documentation.
I’ll try to solve issues in the near future after learning JavaScript properly.
That’s for the docs.meshery.io @shubham-tyagi,
make site
isn’t working becausemake
isn’t installedWSL doesn’t work on my desktop. You carry on with this issue.
Also you could try a hacky technique, in the gemfile change the gem version to whatever your local version is. Then run
bundle install
>bundle exec jekyll serve
. Before making the commit just revert back the change or dont add the gemfile to your commit. (This works only sometimes though, worth a try)Hi @shubham-tyagi Yeah I can look into other beginners issue alongside helping @Susmita-Dey.
@Susmita-Dey You need to have ruby version 2.7.0. You can do that using anything like rvm, rbenv, etc. You just need to have any ruby version manager.
Hi Can I look into the issue as well? I am new to open source, so it would be good beginning point for me.
Before 25th of the month