meshery: [Chore] Update Handlers to use new Meshkit Errors
Current Behavior
Meshery Server (and its other components, like Adapters) use a centralized library, MeshKit, to provide uniform utilities (e.g. raising and logging errors). Currently, Meshery Server uses a now antiquated style of error logging with logrus.
Desired Behavior
Ideally, all use of logrus is replaced with use of MeshKit-style error logging.
Implementation
Meshery Handlers needs to be:
- Updated to use meshkit errors.
- Switch to handler Log instead of
logrus
Handlers to update:
- event streamer
- fetch results handler
- k8sconfig handlers
- load test handler
- load test mesh handler
- load test preferences handler (#3390)
- mesh ops handler
- meshery application handler
- meshery filter handler
- meshery pattern handler
- oam handler (#3387)
- performance profiles handler
- provider handler
- schedule handler
- server spec handler
- session sync handler
- user handler
- Grafana handler
- Prometheus Handler
For reference, you can checkout the grafana handler
and prometheus handler
or the docs.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (15 by maintainers)
@josephmidura, @debjani1413 and @sayantan1413 I have created a child issues and assigned you some handlers to look into. Feel free to ping me in slack or here in Github if you feel stuck or confused.
Anyone wanna assign few of their handlers to @suhaniii? @vijcheru @Chadha93 @samirparhi-dev
This is a fine-looking list, @dhruv0000. This issue makes for a good Epic (
issue/epic
label), which means that those like @josephmidura looking to knockout some of these are encouraged to create Child issues (issue/child
label) to break down this work into bite-sized chunks.