meriyah: Need to process win32 line break correctly

I noticed we skipped lots of test files in test262-parser-tests, I tried to unblock them to see what happens.

For example the first skipped file: https://github.com/meriyah/meriyah/blob/756d990eb3c98487197bade97cb5d34f77a86ea0/test/test262-parser-tests/parser-tests.ts#L9

The 110fa1efdd0868b8.js file contents is

"Hello\
world"

But the file is using win32 line break \r\n which causes issue in meriyah.

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 1
  • Comments: 15 (15 by maintainers)

Commits related to this issue

Most upvoted comments

It turns out a very small bug in existing code, it was sitting there because of missing test coverage. Let’s just patch it for now, worry about the bigger refactoring later.