material-table: v1.68.1 and v1.69.0 use jsPDF v2.0 which throws warning
After upgrading to v1.68.1 I get this in the console:
Compiled with warnings.
./node_modules/jspdf/dist/jspdf.umd.min.js
Critical dependency: the request of a dependency is an expression
Probably related: https://github.com/MrRio/jsPDF/issues/2846
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 37
- Comments: 25 (5 by maintainers)
Commits related to this issue
- Updated npm packages Reverting to material-table 1.68.0 due to warnings caused by 1.68.1; see https://github.com/mbrn/material-table/issues/2326 — committed to jaypalexa/roster by jaypalexa 4 years ago
- FIXME:material-table@1.68.1だとビルド時失敗するので前のバージョンにpin see also https://github.com/mbrn/material-table/issues/2326 — committed to videomark/videomark by kou029w 4 years ago
- Downgrade material-table to 1.68.0 https://github.com/mbrn/material-table/issues/2326 — committed to RevolutionTech/letterboard by RevolutionTech 4 years ago
- Downgrade material-table to 1.68.0 again Damn you dependabot and mbrn/material-table#2326 Fool me once, shame on you. Fool me twice, shame on me. — committed to RevolutionTech/letterboard by RevolutionTech 4 years ago
- Table: export: add link to src spreadsheet, fix deps (hopefully?): Cannot use 1.69.1 and the only way this whole fragile mess works is via `resolutions` in package.json (did it for jspdf-autotable as... — committed to Language-Mapping/language-map by abettermap 4 years ago
I was extremely surprised to see
material-table
depends onjsPDF
for a feature that most of us aren’t probably even using… Hopefully this dependency will become optional in the near feature see #2164 #2168I rolled back from
1.68.1
down to1.68.0
and the warnings are gone. I can now successfully build my React App (whereas build warnings are considered a failure in my CI/CD).Just my opinion, I don’t see how upgrading a major version of a dependency, in this case from
jspdf@1.5.3
tojspdf@2.0.0
, constitutes a patch version in the material-table library. I would think it would at least be a minor version change.Thanks to @merobal for the info that using
jspdf@^2.1.0
fix this issue.If using
yarn
you can pin jspdf version to^2.1.0
in your project’spackage.json
for temporary fix.@merobal All waiting the version 1.69.1.
Still waiting for @mbrn to release the fixes
@victororlyk You could also opt for downgrading to the previous version of
material-table
: 1.68.0 .v1.69.1 is just released, finally 🎉
Still have issue…
Does it work with newest
material-table
, in case of issues with the table look at: https://github.com/MrRio/jsPDF/issues/2846Do we have any news regarding this? I feel the pdf thing add a lot of code and has warnings
@benjaminvdb , thanks it is also working.
Hi, I’m having the same issues:
Output from react-scripts start (I’m using TypeScript):
npm list jspdf: