landmarks: Please don't include hidden landmarks

If a landmark element is hidden or display: none; or visibility: hidden; please don’t include it in the list of landmarks. Maybe also aria-hidden="true".

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 15 (8 by maintainers)

Commits related to this issue

Test for hidden elements * If an element is hidden, ignore it and any landmark it represents and contains (fixes #80). * Also we can use NodeList.forEach() now. — committed to matatk/landmarks by matatk 7 years ago

Most upvoted comments

Thanks for the link @carmacleod; it’s helpful to have context on decisions. I am following the ARIA repo now, so I can keep up with discussions.

matatk on May 20, 2020

I just found a visually-apparent yet aria-hidden landmark in the wild

Wow - almost sounds like a bug. 😃

Agree that visually-apparent but aria-hidden landmarks should be in the list, and annotated. And that the feature should not be optional. 😃

What’s the exact wording in the changelog? Is it “Do not show hidden landmarks”? If so, then yes, it might be less confusing if it said something like, “Do not show hidden, display:none, or visibility:hidden landmarks. Show aria-hidden landmarks with a flag.”

carmacleod on Aug 15, 2018