zsh-autocomplete: fzf trigger sequence (**) does not work as expected (even using control + space)
This is some really cool work. Thanks for sharing it!
Describe the bug
The fzf search menu no longer seems to pop up when the trigger sequence is used when zsh-autocomplete is enabled, even when using the new shortcut—<kbd>control</kbd><kbd>␣</kbd>.
To Reproduce
Steps to reproduce the behavior:
% zsh -df
% [ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
% cat dir/** [TAB]
>
3/3
> dir/file1.txt
> dir/file2.txt
> dir/file3.txt
% source ~/dir/dir/zsh-autocomplete.plugin.zsh
% cat dir/** [CTRL][SPACE]
file1.txt file2.txt file3.txt
Of course, this fixes itself if I run zstyle ':autocomplete:tab:*' completion fzf
. <kbd>tab</kbd> is now controlled by fzf, and the trigger sequence **
works as expected. But then normal autocomplete seems broken at that point.
Expected behavior
I thought <kbd>control</kbd><kbd>␣</kbd> (with zsh-autocomplete) would trigger the kind of behaviour fzf would trigger by hitting <kbd>tab</kbd> normally (without zsh-autocomplete).
Desktop
- OS + distribution: macOS 10.15.5
- Zsh version: 5.7.1
- Plugin version: 33d98129
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 28 (14 by maintainers)
Commits related to this issue
- Add glob completion & improve `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & improve `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & improve `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & improve `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & improve `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & enhance ctrl-space behavior Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & enhance `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & enhance `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Add glob completion & enhance `fzf` integration Address issue #51. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Improve `fzf` integration * Address issue #51. * Improve `menu-select` logic. * Add a setting to disabled `fzf` integration. Address issue #59. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Improve `fzf` integration * Address issue #51. * Improve `menu-select` logic. * Add a setting to disable `fzf` integration. Address issue #59. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
- Improve `fzf` integration * Address issue #51. * Improve `menu-select` logic. * Add a setting to disable `fzf` integration. Address issue #59. — committed to marlonrichert/zsh-autocomplete by marlonrichert 4 years ago
just had a quick look at dev, more hopefully on the weekend:
I’ll try to take a look tomorrow/Sunday. Busy at work right now.
Gave it a quick look. As far as I can tell this seems good!
👍
<kbd>tab</kbd> features seem to be working as expected
kill [TAB]
works as expected (with fzf taking over)**
) with fzfAh, right, I completely forgot about that. 🤦🏽♂️ That explains the
bindkey
output.Thanks! Now I know what to tweak.