zsh-autocomplete: Completion not triggering after `e14687b80`

Please try updating to the latest commit and see if that helps.

Runs perfectly 😄

@paw-lu Please try updating to the latest commit and see if that helps.

@paw-lu Do you think you could put together a minimal, reproducible test case for this that does not use zsh-autocomplete? Then I can ask about it on the Zsh mailing list.

It seems that for some reason, redirecting to that fd when inside a pty breaks things for you. No idea why. But perhaps I can add a test inside the pty to check if the fd is writable.

OK, well, that’s not handy. I wonder why that doesn’t work on CentOS?

@paw-lu Can you give me your $OSTYPE? Perhaps I can conditionally remove it.

I thought you said, though, that 85fdb57 was the first commit that broke it for you? Those redirects were already present in e14687b and that worked for you. It makes me think that it’s not the redirects themselves that are the problem, but rather the way I create the file descriptor.

@paw-lu Can you try reverting commit 85fdb5750d6bddc621df6ba447027c97fadf2bd4 line by line and see which one fixes the problem?

@jocastaneda @paw-lu Thank you for the kind words! 🤗

If you use my software on a regular basis, please consider being a sponsor. 🙂

Does foobar then show up in the log?

yep!

OK, that should be fixed now. That doesn’t explain the other bug, though. 🤔

Well, that looks like it works. I’m kind of baffled by this one.

What happens if you paste this into the command line?

    print $sysparams[pid]
    {
      local REPLY
      zpty _autocomplete__zpty .autocomplete.async.pty '$LBUFFER' '$RBUFFER'
      zpty -w _autocomplete__zpty $'\t'

      local line
      zpty -r _autocomplete__zpty line '*'$'\0'$'\0'
      zpty -r _autocomplete__zpty line '*'$'\0'$'\0'

      # `zselect -t` w/out other args wants an int > 0
      local -i timeout=$(( 100.0 * (min_delay - SECONDS) ))
      (( timeout > 0 )) &&
          zselect -t $timeout
    } always {
      zpty -d _autocomplete__zpty
      (( TRY_BLOCK_INTERRUPT > 0 )) ||
          print -rNC1 - "$SECONDS" "$line"
    }

Can you update to fd801e4ce6e31c2b4e4985a769d8db80da50b098 and try this?

functions -t .autocomplete.async.pty .autocomplete.async.pty.zle-widget

@paw-lu Can you update to 20a301d and then try this?

functions -t .autocomplete.async.pty.completion-widget

And then check the logs again.

OK, try this:

functions -T .autocomplete.async.list-choices.completion-widget
functions -T .autocomplete.async.list-choices.main-complete

Then check the logs again.

@paw-lu Can you go to ${XDG_DATA_HOME:-$HOME/.local/share}/zsh-autocomplete/log and have a look what is in the newest log files there? Any error messages?

Actually, sorry, no, that doesn’t help. As you said yourself, that’s fixed in 85fdb57.

I wonder if it has something to do with you using zsh-5.7.1-0-g8b89d0d. 🤔

7041784 also sometimes gives me .autocomplete.__init__.precmd:31: can't clobber parameter _autocomplete__log_fd containing file descriptor 0 when sourced.

Thanks! That makes it a lot more clear what I need to fix.

@paw-lu Are you saying that the first bad commit for you is 70417848c6cd0715955ce4cbaf4b9ed779c7402c?

If by reinstalling you mean deleting the repo and recloning—that doesn’t seem to help.

Yes, that’s what I meant.

Aha:

% cd $(mktemp -d)
exec env -i PS1='%# ' HOME=$PWD TERM=$TERM zsh -f 
% git clone --depth 1 -- https://github.com/marlonrichert/zsh-autocomplete.git
Cloning into 'zsh-autocomplete'...
remote: Enumerating objects: 59, done.
remote: Counting objects: 100% (59/59), done.
remote: Compressing objects: 100% (54/54), done.
remote: Total 59 (delta 0), reused 29 (delta 0), pack-reused 0
Receiving objects: 100% (59/59), 1.60 MiB | 4.23 MiB/s, done.
% source zsh-autocomplete/zsh-autocomplete.plugin.zsh 
(anon):35: command not found: .autocomplete.__init__
% 

I must have something in my environment that’s making it work when I don’t use a fresh clone. I’ll have to investigate.

It works fine for me on the latest commit:

% cd $(mktemp -d)
exec env -i PS1='%# ' HOME=$PWD TERM=$TERM zsh -f 
% source /Users/marlon/Git/zsh-autocomplete/zsh-autocomplete.plugin.zsh
% git -C ~zsh-autocomplete rev-parse @
112b791326007623c7fdb6234d2f9feb74dae538
% touch file0.txt  file1.txt  file2.txt  file3.txt
% cat
file
file0.txt  file1.txt  file2.txt  file3.txt
Shift-Tab: insert file.txt

Have you tried reinstalling?