csla: DI still giving wrong IContextManager within new scope in LocalProxy (IsStatefulRuntime=true)

@rockfordlhotka @TheCakeMonster All testing good in preview 6 except one last issue - it’s baaaack 😦

AFAIK - this issue only shows up when

1. LocalProxy is being used
2. A new scope is in play (e.g. for ApplicationContextManager instances with IsStatefulRuntime=true)

As you know, in LocalProxy, if in a new scope, we now manually create ApplicationContextManagerAsyncLocal.
But since DI doesn’t create it, DI doesn’t yet have a scoped instance of IContextManager to give others. So the next time (while in that scope) any code uses DI to get an IContextManager, a new instance is given for whatever IContextManager type is registered. (In BSS this ends up being a new instance of ApplicationContextManagerHttpContext)

BUG: So you end up with LocalProxy having an ApplicationContextManagerAsyncLocal while my code gets a separate ApplicationContextManagerHttpContext

Two different IContextManagers on logical server side is a problem. We need to devise a way where, during the new scope in LocalProxy, only one is used and it is always ApplicationContextManagerAsyncLocal.

Back to the chicken-egg scenario:

Maybe you’ll think of a better way, because this is rough, but I think it will work. After brainstorming on this for hours, it’s the only way I can think of that respects DI:

FIRST:

1. Create a new scoped service called “LocalProxyState” which has a bool property “NewScopeExists”.
2. See about making an abstract base class called ApplicationContextManagerFacade which implements IContextManager. This can then be used for 3 below.
3. Make each IContextManager implementation where IsStatefulRuntime=true be a class that inherits from ApplicationContextManagerFacade, and which is a facade wrapper with an ActiveContextManager just like the current Csla.AspNetCore.ApplicationContextManager class.
4. Each of these facade context managers needs to use the LocalProxyState in their CTOR to know if they should create the ActiveContextManager as a ApplicationContextManagerAsyncLocal

SECOND:

1. Immediately after LocalProxy creates the new scope, it will fetch a fresh instance of this service var lpScopState = provider.GetRequiredService<LocalProxyState>() then it sets lpScopeState.NewScopeExists= true
2. LocalProxy should then use DI to get it’s IContextManager and everyone gets one happy scoped instance

If you think it’s a good idea, I could try it in a PR?