rs-tiled: Tileset::tiles does not contain all tiles

Tileset::tiles only contains tiles that have some kind of custom attribute. This makes it confusing to use since it’s not mentioned in the field docs.

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 18 (14 by maintainers)

Most upvoted comments

I’m very happy to share or even give maintenance to someone else. To be on the safe side it would be good if this person had some commits here or on other projects (just so I know they will work on it).

I’m afraid I haven’t had the spare time to give this repo much love.

The same is true for the TMX and JSON tileset formats, which also currently leave out explicit mention of tiles that have no meta-information attached to them. I guess that a mention in the docs could be preferable, since it might be of interest in terms of performance to not create a bunch of empty Tile instances.

Different issue, but when looking at the code, I noticed the Tile struct has pub images: Vec<Image>, but in fact a tile can contain only a single image:

https://github.com/mattyhall/rs-tiled/blob/01f38e3f67f0e0f9956ca26554f3d667d425495b/src/lib.rs#L537-L540

I’m not sure how Rust would deal with such API changes. The loading of image elements should essentially look the same as for the objectgroup element.

Sure. What I meant was, could rs-tiled be a good replacement for macroquad-tiled, if features like xml, deflate and serde could be disabled?

It probably already is a replacement, to be honest. macroquad-tiled is a really small thing covering only things I found personally useful or that fitted nicely to macroquad. If one needs full-featured tiled support - some other crates would be a better choice, no doubts about that 😃

@alexdevteam I’d recommend you open some pull requests for each part of your refactor, so we can get an idea of where you are going and when a few are merged it would give @mattyhall the confidence he needs to make you a maintainer as well.