mapbox-gl-geocoder: Capturing paste event is problematic on mac

Would be good to catch a paste event on geocoder input

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 15 (1 by maintainers)

Commits related to this issue

Most upvoted comments

@edkim I did a patch release of suggestions which included the bug fix for this. npm will pick up the latest patch release even without bumping the version here in package.json (not sure if we should bump it regardless). So simply redoing npm install followed by a rebuild should bring in those fixes.

@tristen What do you think, can we do a new minor version release of mapbox-gl-geocoder? Seems fairly straightforward following https://github.com/mapbox/mapbox-gl-geocoder/blob/master/CONTRIBUTING.md#deploying.

@ogdenstudios https://github.com/mapbox/mapbox-gl-js-docs/pull/391 is updating the examples and they noticed the latest release hasn’t been uploaded to the CDN, so it should be resolved at some point, in the meantime to use 4.7.0 you’ll need to host yourself, but versions older than 4.7.0, but newer than 4.2.0 should be available.

I don’t think the tutorial is covered by the https://github.com/mapbox/mapbox-gl-js-docs repo, but you could probably still open an issue there so the docs team is aware of it.

The fix for the paste event was done in https://github.com/mapbox/mapbox-gl-geocoder/blob/master/CHANGELOG.md#v450

If you’re not seeing this issue on master, I’ll close this ticket, but if it’s still any issue for anyone on the latest version feel free to post back here or open a new ticket.

Ayy, looks like this original issue is resolved in v4.7.0, but the Mapbox docs are only referencing the CDN for v4.2.0.

I tried to hit <script src='https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v4.7.0/mapbox-gl-geocoder.min.js'></script> but got no response there. So I copied the current master branch into my project and the paste event worked without any workaround.

I’m a little new to the plugin ecosystem here. How closely tied are you to the Mapbox docs team? Should I file a report with them or are you able to push a new release up there?

Thanks, Andrew!

Let me see if I can adapt my workaround a little smarter over the weekend. I can test it out on my mac and I’ll submit a PR. Feel free to assign this issue to me if that’s how you do things around here.