manga-py: Viz Shounen Jump downloads fail because of "sn't image"
Bug report
Environment:
| Description | Data |
|---|---|
| OS | macOS 11.2.1 |
| Python version | 3.9.1 |
| Pip version | 21.0.1 |
| Manga-py version | 1.26.1 |
| URL | https://www.viz.com/shonenjump/chapters/my-hero-academia |
To Reproduce:
Run the following command to get the latest chapter (free):
manga-py https://www.viz.com/shonenjump/chapters/my-hero-academia --reverse-download --max-volumes 1
Error
I get the following error messages
N/A% (0 of 250) | | Elapsed Time: 0:00:00 ETA: --:--:--"WARNING:/manga_py/base_classes/archive.py:56:2021-02-16 14:13:45,167:File "/var/folders/7y/bzfzj1nx5wb5npffzj76gq500000gn/T/.PyMangaDownloader/temp_6381/000_get_manga_url" isn't image"
"WARNING:/manga_py/base_classes/archive.py:56:2021-02-16 14:13:45,167:File "/var/folders/7y/bzfzj1nx5wb5npffzj76gq500000gn/T/.PyMangaDownloader/temp_6381/001_get_manga_url" isn't image"
0% (1 of 250) | | Elapsed Time: 0:00:00 ETA: 0:02:35
...
Since it worked fine a week ago I guess Viz changed the API.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 17 (14 by maintainers)
Commits related to this issue
- Patch #366 (viz_com provider error) — committed to manga-py/manga-py by 1271 3 years ago
I just checked again. Now it works as expected. Thanks.
Indeed, my bad ! Thank for your time !
Ok, problems comes from the
save_filemethod (see https://github.com/manga-py/manga-py/blob/stable_1.x/manga_py/providers/viz_com.py#L208). It’s now always replaced by the stock one. replacing it with the one above “solves” the problem. I’ll see if i can find a clean way to do that.I didn’t check before, but now that I did I can confirm that it works with version 1.25.0.