manageiq: List migrations that don't use migration stub (good migration gem) and other migration issues

https://trello.com/c/DXKp4OGf/183-add-good-migrations-gem-to-prevent-rails-autoloading-of-models-in-migrations

Migrations:

• 20131107000917_expand_dialog_field_default_value_size.rb - ReservedMixin module in app/
• 20140201040548_add_update_repo_name_to_miq_database.rb - ReservedMixin module in app/
• 20140214191729_enhance_firewall_rules_for_neutron_networking.rb - ReservedMixin module in app/
• 20140421150958_create_miq_groups_users_join_table.rb - ReservedMixin module in app/
• 20150206150955_migrate_miq_database_registration_organization_display_name_out_of_reserves.rb ReservedMixin module in app/
• 20150407144345_add_kerberos_to_ext_management_system.rb - ReservedMixin module in app/
• 20160119125950_add_created_on_for_container_entities.rb -access to models from CONTAINER_TABLES
• 20160317194215_remove_miq_user_role_from_miq_groups.rb (Entitlement)
• 20160418141210_add_read_only_to_miq_alert.rb (MiqAlert, YAML ??)

Specs:

• 20150522161336_add_container_entities_type_spec.rb(Container*,…)
• spec_helper is loaded in spec migrations (EmsRefresh) 20141121200153_migrate_ems_attributes_to_endpoints_spec.rb 20151204143045_set_correct_sti_type_on_openstack_cloud_volume_spec.rb 20151222103721_migrate_provider_attributes_to_endpoints_spec.rb 20160120151642_migrate_url_from_provider_to_endpoints_spec.rb
• 20140201040548_add_update_repo_name_to_miq_database_spec (Reserve, MiqDatabase)
• 20140409134713_move_log_collection_depot_settings_to_file_depot_spec (Authentication, …)
• 20140410132430_subclass_file_depot_by_protocol_spec (FileDepot)
• 20150206150955_migrate_miq_database_registration_organization_display_name_out_of_reserves (Reserve, MiqDatabase)
• 20151221134925_remove_sat5_repo_config_spec (Authentication)
• 20160418141210_add_read_only_to_miq_alert.rb

Need to convert to use active-record:

• https://github.com/ManageIQ/manageiq/blob/master/db/migrate/20151021093644_set_correct_sti_type_on_cloud_network.rb
• https://github.com/ManageIQ/manageiq/blob/master/db/migrate/20151021095831_set_correct_sti_type_on_cloud_subnet.rb
• https://github.com/ManageIQ/manageiq/blob/master/db/migrate/20160406195810_add_id_primary_key_to_join_tables.rb and remove ApplicationRecord

Need to add migration spec:

• 20160119125950_add_created_on_for_container_entities.rb
• 20140218232357_add_group_and_user_columns_to_miq_widget_contents.rb
• 20150206150955_migrate_miq_database_registration_organization_display_name_out_of_reserves.rb
• 20150311181430_add_draft_to_orchestration_templates.rb
• 20150822102141_fix_more_foreman_types.rb
• 20150823120001_namespace_ems_openstack_availability_zones_null.rb
• 20150907163347_confirm_all_class_renames.rb
• 20150909023532_namespace_ems_azure.rb
• 20160203101130_add_orderable_to_orchestration_templates.rb
• 20151021095831_set_correct_sti_type_on_cloud_subnet.rb
• 20151021093644_set_correct_sti_type_on_cloud_network.rb

Other issues:

• 20160120151045_add_url_to_endpoints_spec.rb is empty -> remove (spec is not needed)
• remove self.inheritance_column = :_type_disabled from stub classes: HostsStorage, MiqSet,MiqGroupsUsers, MiqDatabase, MiqAlert, MiqDialog, MiqEventDefinition, ScanItem, MiqWidgetContent, TimeProfile, MiqServer, Zone, User, MiqAeNamespace, MiqGroup, PxeServer, MiqSearch, Endpoint, OperatingSystemFlavor, MiqSchedule, ContainerService, ContainerServicePortConfig, ContainerCondition, MiqReportResult, BinaryBlob, Relationship, MiqEventDefinition, BlacklistedEvent, Tenant, TenantQuota, MiqUserRole, ContainerImage, MiqProductFeature, ServiceTemplateCatalog, MiqRegion in all migrations