magento2: Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment

@hostep, thank you for your report. The issue is already fixed in 2.2.0

I can confirm this bug is still present in version 2.1.6. Will it be fixed in version 2.2?

This has nothing to do with nginx configs. Magento checks those files via the file system.

Same problem. Server: Ubuntu 16.04, Nginx 1.10, PHP 7, MySQL 5.7, Magento 2.1.3 CE clear. Command php /var/www/html/bin/magento setup:static-content:deploy --theme Magento/luma ru_RU don’t help. I think Magento 2 will never work well. Throughout the year, I’m trying to run project on Magento 2. Every step - errors in Magento 2.

Hi @hostep

Thanks for reporting. We’ve created internal ticket MAGETWO-62660 to investigate and fix this issue.

I’m not 100% sure if this is the same bug, but after debugging the static content deployment process for a couple of hours, I found out that that in Magento\Framework\Translate#setConfig() on line 212, getId() always returns null. This is because the loaded themes don’t have a theme_id in their _data since they’re loaded from the filesystem (in 2.1.x, this code was in Magento\Theme\Model\Theme\Collection) instead of the database. That leads to this if statement to always return true and never loading the theme translations.

(I used a random commit for the links so the line numbers don’t change when the branch is updated.)

Closing as this was fixed somewhere in Magento 2.2.x

The only reason this ticket was still open is because it wasn’t fixed yet in Magento 2.1 But Magento 2.1 will be EOL after its final release 2.1.18 next week, so let’s just close this ticket.

Thx man! You save my day 😃

I think I know this error and I solved it by the following patch :

--- a/vendor/magento/module-translation/Model/Json/PreProcessor.php
+++ b/vendor/magento/module-translation/Model/Json/PreProcessor.php
@@ -77,11 +77,12 @@ public function process(Chain $chain)
             if ($context instanceof FallbackContext) {
                 $themePath = $context->getThemePath();
                 $areaCode = $context->getAreaCode();
-                $this->translate->setLocale($context->getLocale());
             }
 
             $area = $this->areaList->getArea($areaCode);
             $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);
+
+            $this->translate->setLocale($context->getLocale())->loadData($areaCode, true);
 
             $chain->setContent(json_encode($this->dataProvider->getData($themePath)));
             $chain->setContentType('json');

Thanks as always! ❤️

@chaohe / @hostep This is what I get for relying on the release notes! Ouch.

I’m reverting that change in the gem and including it in v0.7.1, which I’ll push up shortly.

There is a next release for 2.1? Do you know when?

This issue has already been fixed in develop branch. Internal ticket for ver. 2.1. - MAGETWO-63309 - it is planned for one of the next releases.

I re-cofirm @PascalBrouwers’s issue. The Translation class should not be a singleton I guess. Took me a while to understand why this happens.

Check in your server configuration that the jzon files are processed by Nginx as a static file.

Under the nginx/apache settings in plesk, I tried turning on “Serve static files directly by nginx” with the following default files active:

ac3 avi bmp bz2 css cue dat doc docx dts eot exe flv gif gz htm html ico img iso jpeg jpg js mkv mp3 mp4 mpeg mpg ogg pdf png ppt pptx qt rar rm svg swf tar tgz ttf txt wav woff woff2 xls xlsx zip xml json

Hi @hostep

We’ve added the bug and your workaround to Known Issues for both CE and EE Release Notes (Magento 2.1.3).

Thanks for your support!