magento2: Magento 2.4 catalog products sort by position is not working

nothing working.

Please try solution from here https://www.ecomplugins.com/blog/how-to-fix-magento-2-4-x-sort-by-position-category-products-issue/

This fixed for me 😃

vendor/magento/module-catalog/Block/Product/ProductList/toolbar.php at line 221 Remove the if its a position sort function, it works fine with the else function! So you get:

public function setCollection($collection)
    {
        $this->_collection = $collection;

        $this->_collection->setCurPage($this->getCurrentPage());

        // we need to set pagination only if passed value integer and more that 0
        $limit = (int)$this->getLimit();
        if ($limit) {
            $this->_collection->setPageSize($limit);
        }
        if ($this->getCurrentOrder()) {
                $this->_collection->setOrder($this->getCurrentOrder(), $this->getCurrentDirection());
        }
        return $this;
    }

In our case we are running Magento 2.4.2 and Porto theme (latest version 4.0.0). Porto theme is coming with Mageplaza_Layered_Navigation + Mageplaza_Ajax_Layer extensions which interfere with the product sort on category pages.

We found the problem in: app/code/Mageplaza/LayeredNavigation/Model/ResourceModel/Fulltext/Collection.php The product collection gets sorted in the ElasticSearchApply()-function in the following way: $this->getSelect()->where(‘e.entity_id IN (?)’, $ids); $this->getSelect()->reset(Select::ORDER); $this->getSelect()->order(new Zend_Db_Expr(‘FIELD(e.entity_id,’ . implode(‘,’, $ids) . ‘)’));

So no matter what you set in the category page toolbar (position, name, price, ascending or descending) it always sorts the products by the entity_id attribute.

Its not enough if you disable Mageplaza_Layered_Navigation in the backend (I don’t know why right now).

The solution for us was to disable these extensions completely like this: bin/magento module:disable Mageplaza_LayeredNavigation --clear-static-content bin/magento module:disable Mageplaza_AjaxLayer --clear-static-content bin/magento setup:static-content:deploy bin/magento setup:di:compile

Now all the standard sort options work perfectly fine. Even though this is not a solution for the main problem some are facing I hope this maybe helps someone with a similar problem caused by this theme/extension 😃

@Jilco 2.4.4

@vipin12117

I have commented the file changes instead of removing them so you can see the changes.

vendor/magento/module-catalog/Block/Product/ProductList/toolbar.php at line 221

    public function setCollection($collection)
    {
        $this->_collection = $collection;

        $this->_collection->setCurPage($this->getCurrentPage());

        // we need to set pagination only if passed value integer and more that 0
        $limit = (int)$this->getLimit();
        if ($limit) {
            $this->_collection->setPageSize($limit);
        }
        if ($this->getCurrentOrder()) {
/*    
             if (($this->getCurrentOrder()) == 'position') {
                $this->_collection->addAttributeToSort(
                    $this->getCurrentOrder(),
                    $this->getCurrentDirection()
                );
            } else {
*/
                $this->_collection->setOrder($this->getCurrentOrder(), $this->getCurrentDirection());
//            }
        }
        return $this;
    }

I am using Porto theme too and had encountered this problem on Magento 2.4.2. After above comment by @tabunsa, I looked up release notes for mageplaza’s layered navigation module and ajax module and realized that they had newer releases that were compatible with 2.4.2 and they fixed the bug. I used composer update mageplaza/* to update the the latest 4.1.1 module for layered navigation the issue is now resolved for anyone else who encountered this problem.

@MarkADurham in our case we are WeltPixel_GoogleTagManager and it is calling WeltPixel\GoogleTagManager\Block\Category.php and that create issue, but after upgrade it is fixed

So in your case may be some other module go to this file Magento\Elasticsearch7\SearchAdapter\Adapter.php

public function query(RequestInterface $request) : QueryResponse
    {
    	foreach(debug_backtrace() as $t) {       
    	if(isset($t['file']))       
   echo $t['file'] . ' line ' . $t['line'] . ' calls ' . $t['function'] . "()<br/>";
}; exit

and debug which module called other than magento

@MarksAfanasevics i m faced similar issue and finally debug more than 1 day and found issue due to WeltPixel_GoogleTagManager

Hope it will help you