magento2: Can't cancel removal of a block or container in layout by setting remove attribute value to false
I inherit the blank theme and i wanted to have the top.links visible in the checkout so i created this file:
Vendor/Theme/Magento_Checkout/layout/checkout_index_index.xml containing this:
<?xml version="1.0"?>
<!--
/**
* Copyright © 2015 Magento. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="2columns-left" xsi:noNamespaceSchemaLocation="../../../../../../../lib/internal/Magento/Framework/View/Layout/etc/page_configuration.xsd">
<body>
<referenceContainer name="header.panel" remove="false"/>
</body>
</page>
Reading This i understand, that it sould now be possible to cancel a removal instruction with the above instruction, but it doesn’t seem to work.
I know the file is parsed, and included in the layout, because if i add a block from this file it will show up on the checkout page.
/Thomas
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Reactions: 17
- Comments: 25 (13 by maintainers)
Commits related to this issue
- MAGETWO-54935: [Github #1931] Cancellation of element removal in layouts doesn't work -- integration test — committed to magento/magento2 by deleted user 8 years ago
- Merge pull request #516 from magento-frontend/PR Fixed issues: - MAGETWO-57432: Functional test Magento\Bundle\Test\TestCase\CreateBundleProductEntityTest is failed - MAGETWO-55510: "Client side le... — committed to magento/magento2 by MomotenkoNatalia 8 years ago
- MAGETWO-54935: [Github #1931] Cancellation of element removal in layouts doesn't work -- integration test — committed to quisse/magento2 by deleted user 8 years ago
This problem can be reproduced by removing an element in a parent theme and trying to cancel it in a child theme.
The GitHub issue tracker is intended for technical issues only. Please refer to the Community Forums or Magento Stack Exchange site for technical questions. In your case, the programming questions forum is likely the most appropriate. Feel free to reopen this issue if you think you have encountered a bug in Magento 2.
@KrystynaKabannyk I hate to underline the obvious, but if the bug was discovered on 2.1.x and then reportedly “fixed”, it is commonly expected to see that fix in the closest patch (2.1.x) release.
Considering that for many of the merchants the switch to 2.2 will probably be somewhat painful, resource-heavy (see this marvelous list of backwards-incompatible changes for a taste) and delayed for at least a couple more months, it would make sense to have it on the 2.1.x branch as well. Furthermore, someone from the community just might want this fix badly enough and make pull request aiming
2.1-develop.Either that, or some disclaimer saying that “this is a known issue that won’t ever be fixed in 2.1. Please move along to 2.2”. You do know that there are people re-testing every bug they have encountered earlier after each new release in order to see if it got fixed? right?
Anyhow, having the issue marked as “closed” (while there isn’t any straightforward way to use it available to ordinary users) is very misleading. Could you at least leave the issue open until 2.2.0 gets released?
Hi @magento-engcom-team, I am having a bad case of deja vu and I just hope that this message above was an automated one and someone has just missed the discussion above (as opposed to outright ignoring it and turning this thing over again).
The issue is reported and reproduced on 2.1.x The issue isn’t fixed on 2.1.x How come it’s “closed” already (again) ?!
Just trying to make sense of it, please help me understand the issue flow here. I mean, this isn’t your internal JIRA where the only thing that matters is whether is fix is implemented already. People here care whether they can update to the latest release in order to have the bug gone (and they can’t, in this case)
@magento-engcom-team @KrystynaKabannyk - Magento committed to backporting this into 2.1 and has marked the ticket as Done (even after @korostii mentioned that Magento may be misunderstanding). However, it’s not even in 2.1.10-dev. Please fix the status of this report and update the community on an ETA.
hi @korostii, we reviewed the issue again and made the decision to backport it into 2.1.x. Internal ticket for it is created MAGETWO-69715. Thank you for raising this issue again!
The issue already fixed and will be available in release 2.2.0 very soon
come on guys. almost 4 months to fix this?
Thank god for people like @korostii. Thanks for the effort @KrystynaKabannyk.
Hi @KrystynaKabannyk, could you please reopen this issue (until the fix appears in a released 2.1.x version)? Thanks in advance.
@philippsander issue is waiting to be merged
Any news on this yet Magento? It doesn’t even look it’s been been internally raised or acknowledged yet.
CC @daim2k5
Please merge this in some upcoming release. Thanks.