magento2: [2.3.6 & 2.4.1] Submitting invalid create account form leaves the submit button disabled

Preconditions (*)

  1. Magento 2.3.6 and 2.4.1
  2. Confirmed on 2.4.1 composer installation Note(16 oct 2020): on git 2.4-develop branch it possibly not reproducible because the branch is not synced with release code yet

Intitial case for 2.3.6

Steps to reproduce (*)

  1. Install clean Magento 2.3.6 or 2.4.1
  2. Go to the create a new account form
  3. Press the ‘Create an Account’ button without filling in any fields
  4. Notice that the button turns inactive/disabled

Expected result (*)

  1. Button should stay active/enabled

Actual result (*)

  1. Button stays disabled, even after filling in all required fields, so you can’t submit the form

Case for 2.4.1

Steps to reproduce (*)

  1. Go to Create New Customer Account
  2. Fill form but do some mistake e.g. in password fields. Example: – password/Confirm password is not equal – password/Confirm password is not long enough
  3. Click “Create an Account” button
  4. Result: Form validation is failed and “Create an Account” button is not clickable(disabled)
  5. Correct/fix a mistake(s)

Expected result (*)

  1. Button should stay active/enabled
  2. User should be able to create new account

Actual result (*)

  1. Button stays disabled, even after filling in all required fields with valid/correct data
  2. Customer is NOT able to create new Account

30513_p1

Discussion

This is pretty bad because when people make a single mistake on a form, they can no longer submit the form after correcting their mistake, they need to refresh the form and loose all the data they entered and enter them again.

Maybe other forms are affected as well, not tested yet…

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • < ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

| Patch is released in MQP|borderStyle=dashed|borderColor=#cccccc|titleBGColor=#dddddd|bgColor=#e3ffea | | — | |

  • MQP release: 1.0.11

  • Patch ID MC-38509

  • Are there any additional actions required after the patch installation to make it work? N/A

  • Compatible with Magento versions: Magento Commerce and Magento Commerce Cloud 2.3.6, 2.4.1 Check using Patch Checker tool

  • Fix version 2.4.2 |

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Reactions: 2
  • Comments: 25 (20 by maintainers)

Most upvoted comments

I can confirm this patch fixes the problem on Magento 2.3.6 (we aren’t using Magento 2.4.x yet, but I assume it will work as well).

For the people who install patches using some composer patch plugin, here’s our adapted version:

MC-38509-Customer.txt (rename from .txt to .diff)

And its definition:

        "magento/module-customer": {
            "MC-38509 - Create New Customer Account patch": "vendor_patches/MC-38509-Customer.diff"
        }

Thanks to Magento/Adobe devs for picking up this so quickly and thanks to my colleague @sorinbarnutiu for discovering the bug in the first place!

@hostep

The issue was closed by mistake. at this moment Magento team has fixed it, internal PR is ready(CR and QA passed) but not merged into the main code-base. As soon as it will be merged related commits can be found using search based on internal ticket key MC-38509 Example: https://github.com/magento/magento2/search?q=MC-38509&type=commits

Sorry for inconvenience

@hostep @chiranjeevi-cj @mrtuvn jFYI

The internal team is working on the fix for this issue. Internal PR is ready and in the code review stage

The related internal Jira ticket MC-38509 was closed as Fixed. Related commits can be found by search https://github.com/magento/magento2/search?q=MC-38509&type=commits

It looks like Magento released a patch for this issue over here: https://magento.com/tech-resources/download#tab-36 (search for MC-38509)

@magento I am working on this

@hostep
After little-bit deep investigation, i found steps to reproduce it. Thank you for report!

If you not mind i will update the description and steps to reproduce

Steps:

  1. Go to Create New Customer Account
  2. Fill form but do some mistake e.g. in password fields. Example: – password/Confirm password is not equal – password/Confirm password is not long enough
  3. Click “Create an Account” button
  4. Result: Form validation is failed and “Create an Account” button is not clickable(disabled)
  5. Correct/fix a mistake(s)

Expected result (*)

  1. Button should stay active/enabled
  2. User should be able to create new account

Actual result (*)

  1. Button stays disabled, even after filling in all required fields with valid/correct data
  2. Customer is NOT able to create new Account

30513_p1