macchina: toml config ignored

Describe the bug macchina.toml settings are being ignored

To Reproduce

export XDG_CONFIG_HOME="$HOME/.config"
cd $XDG_CONFIG_HOME && mkdir macchina && cd macchina
wget macchina.toml https://raw.githubusercontent.com/Macchina-CLI/macchina/main/macchina.toml

I have restarted the terminal, re-sourced my shell configurations and so forth, but no changes occur. Must one specify explicitly that macchina must be reading the config via a flag or so?

Expected behavior The configuration .toml changes the appearence of macchina.

System Information

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 38 (24 by maintainers)

Commits related to this issue

Fix #97 — committed to Macchina-CLI/macchina by 123marvin123 3 years ago

Most upvoted comments

Amazingly enough it seems that the line that breaks the code is:

palette         = "Light"

in the theme definition.

Your example works fine; I was curious and I tried with other themes, like Hydrogen and Helium - and they still broke. So I commented out one line at a time (monkey debugging method 😝 ) and saw that if yo remove palette = ... from any theme they work just fine. Likewise, if you add it to your example, it breaks again as well.

Can you confirm this is the case for you as well? See below for demo:

https://user-images.githubusercontent.com/15387611/146459630-f0f4cac3-3af9-4c8b-b1c0-af7ff33b3324.mov

Now the Lithium theme does have its own palette section in the .toml, however the same behaviour happens with Hydrogen and Helium (namely removing palette = ... makes all work fine).

gennaro-tedesco on Dec 16, 2021

Thank you for the suggestion. I have added a --config flag as well as MACCHINA_CONF environment variable both of which can set the config file.

uttarayan21 on May 19, 2021

Updating to

macchina --version
macchina     6.0.5
libmacchina  6.0.0

all seems restored and fine again, I have tried with different configurations and all work well!

gennaro-tedesco on Jan 9, 2022

Awesome, I have installed it and confirm the changes with the $MACCHINA_CONF work as intended!

gennaro-tedesco on May 27, 2021

Woow, thank you for your quick effort! I guess you are referring to https://github.com/Macchina-CLI/macchina/pull/98.

Thank you again and keep up the awesome macchina!

gennaro-tedesco on May 19, 2021