lychee: Wrong error on emails in Gitlab-CI

Hi, lychee in GitLab-CI wrongly reports error on email addresses, see: https://salsa.debian.org/faust/go-team.pages.debian.net/-/jobs/1427125#L150-L151

screenshot_20210209_154154

Here is the yaml part:

check:
  stage: check
  script:
    - apt-get update -qq && apt-get install -y -qq wget
    - wget -qO- "https://github.com/lycheeverse/lychee/releases/download/v0.5.0/lychee-v0.5.0-x86_64-unknown-linux-gnu.tar.gz" | tar -xz
    - ./lychee --verbose --exclude="irc://irc.debian.org:6667" --exclude="https://anonscm.debian.org" build/*.html

When running it locally, no error is detected:

❯ ./lychee --verbose --exclude="irc://irc.debian.org:6667" --exclude="https://anonscm.debian.org" build/*.html | grep @
✅ git@salsa.debian.org [200 OK]
✅ team+pkg-go@tracker.debian.org [200 OK]

Am I missing something?

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 18 (18 by maintainers)

Most upvoted comments

Your guesses are correct! Salsa gitlab instance was upgrated very recently. I will make deeper tests in the next days and keep you informed if I find something interesting. Closing this as the skip email option seems OK now.

fauust on Mar 31, 2021

Oh my. 🤦 Forgot to pass the option to the builder. #200 (nice, even number!) should fix this. Added a unit- and and integration test to make sure it never breaks again.

mre on Mar 29, 2021

The exclusion is working, but the parsing of email addresses happened before exclusion; and the parsing failed. @pawroman fixed that in #177 and the change got merged to master. The release of 0.6 is blocked on https://github.com/lycheeverse/lychee/issues/59#issuecomment-798677637 at the moment.

mre on Mar 22, 2021

and I have just checked, the email check works fine on GitHub actions: https://github.com/fauust/docker-systemd/runs/1871010280?check_suite_focus=true#step:4:22

fauust on Feb 10, 2021