LuckPerms: Error with MassiveCombat

Ever since installing LP I’ve been getting this console spam:

[18:28:48 ERROR]: Could not pass event EventMassiveCorePlayerLeave to MassiveCombat v2.13.1
org.bukkit.event.EventException: null
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:72) ~[patched_1.12.2.jar:git-Paper-1428]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:515) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:500) [patched_1.12.2.jar:git-Paper-1428]
        at com.massivecraft.massivecore.event.EventMassiveCorePlayerLeave.run(EventMassiveCorePlayerLeave.java:84) [MassiveCore.jar:?]
        at com.massivecraft.massivecore.engine.EngineMassiveCorePlayerLeave.runQuit(EngineMassiveCorePlayerLeave.java:57) [MassiveCore.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor56.execute(Unknown Source) [?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) [patched_1.12.2.jar:git-Paper-1428]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:515) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:500) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.PlayerList.disconnect(PlayerList.java:429) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1147) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.NetworkManager.handleDisconnection(NetworkManager.java:343) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.ServerConnection.c(ServerConnection.java:184) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:941) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:427) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:767) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:665) [patched_1.12.2.jar:git-Paper-1428]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.NullPointerException: attachment
        at com.massivecraft.massivecore.util.PermissionUtil.setAttachmentPermissions(PermissionUtil.java:480) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:231) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:218) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:212) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.tickFlagged(MPlayer.java:287) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isFlagged(MPlayer.java:350) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isEnabled(MPlayer.java:102) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isEnabled(MPlayer.java:97) ~[?:?]
        at com.massivecraft.massivecombat.engine.EngineLogout.listener(EngineLogout.java:53) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor126.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1428]
        ... 21 more

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 18 (5 by maintainers)

Commits related to this issue

Add workaround for plugins adding/removing/modifying permission attachments via reflection (#1024) who knows why they're doing it, it's not even beneficial for performance... — committed to LuckPerms/LuckPerms by lucko 6 years ago

Most upvoted comments

MassiveCore (a lib used by MassiveCombat) is doing some very stupid things in order to modify attachment permissions. They absolutely should not be doing this - there is little to no benefit of their approach here.

I’ve added a workaround for it in LP (see the commit above) - but just want to be clear that this is absolutely an issue with MassiveCore, not LuckPerms.

lucko on May 30, 2018

@lucko Totally not your fault, and the issue has been reported to the author for a long time now! No response from the original author.

Opened issue: https://github.com/MassiveCraft/MassiveCore/issues/341

It sucks that we need to rely on you on fixing something that it’s not your fault, but we are very grateful for it and for your amazing plugin. Thank you lucko.

PatoTheBest on May 31, 2018

Try with 4.2.18, I’ve made further changes and tested it with MassiveCombat

seems to be working ok

f4e4f727dd835463efbe40570e5dda2344273722

lucko on May 30, 2018