laravel-actions: Class hash does not exist

I’m getting this Class hash does not exist when running composer update.

Laravel 5.8: Failing Laravel 5.7: Successful

Found out it was this package with:

"extra": {
    "laravel": {
      "dont-discover": [
        "lorisleiva/laravel-actions"
      ]
    }
  },

Specs: Laravel Framework 5.8.19

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 2
Comments: 28 (15 by maintainers)

Commits related to this issue

:ambulance: Override event dispatcher using extenders See #4 — committed to lorisleiva/laravel-actions by lorisleiva 5 years ago
:ambulance: Use boot instead of register in service provider See #4 — committed to lorisleiva/laravel-actions by lorisleiva 5 years ago

Most upvoted comments

New release v0.1.2 tagged.

Thanks for your help everyone. 🍺

Feel free to reopen this issue if the new release causes side effects.

lorisleiva on Jun 1, 2019

@lorisleiva Solved my issue right away moving events to boot method. Was just starting to look at what’s different in 5.8 because I could not believe that 5.7 works & 5.8 does not work with no changes to internals. Glad you figured it out!

Just installed dev-master & so far it’s working on discover.

dragonfire1119 on Jun 1, 2019

@syropian Awesome, thanks. I’ll do a fork to make sure I don’t break anything in your app. 🙂

lorisleiva on Jun 1, 2019

@lorisleiva There must have been something that changed in 5.8 from 5.7 to make this error out? Because the exact same project with the exact same providers are working on 5.7 but not 5.8.

dragonfire1119 on May 31, 2019

I don’t really like the idea to use actions as listeners | jobs. It clearly violates the single responsability principle. Besides that the implementation is also horrible 😦 overriding the laravel dispatchers is not something you want to do (especially not from a third party package).

If you do want to go this way. You might want to consider disabling this behavior by default. And allow people to register it themselves manually in the boot() method. So they actually know that the dispatchers are being overriden.

anthonyvancauwenberghe on May 31, 2019

Argh, that’s annoying. I haven’t manually tested it with a 5.8 application yet so I’m going to try with a fresh 5.8 Laravel install and see if I can reproduce the issue. Thanks again for reporting this bug, I’ll keep you posted.

lorisleiva on May 29, 2019