object.assign: Tests fail when SES is used
If https://github.com/ljharb/object.assign/blob/main/test/ses-compat.js#L15 is changed to require('.'), so it runs the tests:
Boolean.prototype.valueOf.call(require('.')(true)) fails (altho Boolean.prototype.valueOf.call(Object.assign(true)) still succeeds).
cc @kumavis
We need to figure out if this is a bug in the entry point, or a bug in SES.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 29 (17 by maintainers)
Commits related to this issue
- Adapt to override-mistake-fix pattern Fixes https://github.com/ljharb/object.assign/issues/79 ``` // Detect when the getter of an accessor // alleges that it was originally a data property which... — committed to erights/es-abstract by erights 4 years ago
- [patch] `GetIntrinsic`: Adapt to override-mistake-fix pattern Fixes https://github.com/ljharb/object.assign/issues/79 ``` // Detect when the getter of an accessor // alleges that it was originally a... — committed to erights/es-abstract by erights 4 years ago
Scratch that. The getter itself should work independent of
thisbinding. Only the setter cares about thethisbinding.