multi-gitter: Github actions are not used when determining PR status
Unless I have missed the way to do it, it looks like the merge sub-command will just forcibly merge PRs, even if status checks have not passed, or a reviewer has not approved it.
I think this would be quite a nice option to add. I could currently run multi-gitter status to generate a list of repos with status Approved, and then use this to call multi-gitter merge, but mistakes could still be made, and PRs could be merged by accident.
Perhaps two boolean flags could be added:
--require-approval--require-status-checks
To clarify, this is a problem because I am an administrator and can bypass branch protection rules.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 16 (12 by maintainers)
From your second comment, it seems that the changes detect failing GitHub actions as expected, which was the intended change, so that is good. Even though you have the additional use case of ignoring it. Could I get an explicit confirmation of this? 🙂
I think that multi-gitter should have the option to respect the number of approvers settings. Maybe with the name you suggested in the original comment
--require-approvals. But I don’t think that should be the default behaviour since most users want to make the changes without any manual labor. Could you maybe create a separate issue specifically for that? So that any discussions are isolated to that specific topic. I do intend to close this issue if the problem of GitHub actions not working as other CIs becomes solved.I have a hard time seeing the use case of pushing code that is not working. And not setting an explicit requirement that code can never be merged that isn’t passing CI should not change the behavior of multi-gitter to always merge broken code. But if you have a requirement to ignore this, please create a separate issue for this as well so that it could be discussed separately.