lightdash: Input field suggestions should not overlap action buttons

Description

This affects all modals with inputs

If I type something, it will autocomplete with some results.

Screenshot from 2022-11-24 10-03-33

Screenshot from 2022-11-24 10-03-44

The problem is that if I want to save I need to click save button, which is behind the result list. To hide the result list I need to click somewhere in the modal . Clicking outside of the modal closes the modal

Pressing ESC closes the modal entirely, not just the popup (this could be another issue)

My suggestion might be to have a fixed width for the results that will not overlap the buttons.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 16 (12 by maintainers)

Most upvoted comments

Yeah, that works, we’ll have to make sure clicking outside the modal doesn’t close the modal, but only while selection is open…

agreed to keep all modals open even if you click outside. that should be a simple fix

Do we need the history on inputs at all? @TuringLovesDeathMetal @PriPatel Turns out I always disable that from settings when I install chrome 😄

@rephus is that a native text input history?

@IrakliJani yes

@rephus what browser you using ?

How it looks in chrome:

Screenshot 2022-12-08 at 10 42 20 Screenshot 2022-12-08 at 10 43 32

Should we fix this by preventing browsers from showing the text input history in those inputs?