libssh2: libssh2 official release (1.9.0 tarball is missing test files
Describe the bug libssh 1.9.0 release tarball has missing files.
To Reproduce Try building official release tarball for 1.9.0 using CMake. Configure step with default option fails:
CMake Error at tests/CMakeLists.txt:155 (add_executable):
Cannot find source file:
test_public_key_auth_succeeds_with_correct_ed25519_key_from_mem.c
Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
.hpp .hxx .in .txx
Expected behavior Source tarball should build with CMake.
Version (please complete the following information):
- All platforms, v1.9.0
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 1
- Comments: 16 (12 by maintainers)
Commits related to this issue
- moved runtime tests into test files #379 No longer remove test files based on OpenSSL version to hopefully resolve the release build issue. — committed to willco007/libssh2 by willco007 5 years ago
- moved runtime tests into test files #379 No longer remove test files based on OpenSSL version to hopefully resolve the release build issue. — committed to willco007/libssh2 by willco007 5 years ago
- add file missing from the released tarball see: https://github.com/libssh2/libssh2/issues/379 — committed to AnacondaRecipes/libssh2-feedstock by jjhelmus 4 years ago
- add file missing from the released tarball see: https://github.com/libssh2/libssh2/issues/379 — committed to conda-forge/libssh2-feedstock by jjhelmus 4 years ago
- Try 1.9.0 with Ninja (#35) * updated v1.9.0 * MNT: Re-rendered with conda-build 3.18.2, conda-smithy 3.3.7, and conda-forge-pinning 2019.06.18 * add file missing from the released tarball see: htt... — committed to conda-forge/libssh2-feedstock by xhochy 4 years ago
- Makefile.am: include all test files in the dist #379 File: Makefile.am Notes: No longer conditionally include OpenSSL specific test files, they aren't run if we're not building against OpenSSL 1... — committed to libssh2/libssh2 by bagder 4 years ago
- Makefile.am: include all test files in the dist #379 File: Makefile.am Notes: No longer conditionally include OpenSSL specific test files, they aren't run if we're not building against OpenSSL 1... — committed to willco007/libssh2 by bagder 4 years ago
I don’t think changing an already released tarball is a good idea. I’m all for a follow-up release though. I personally then prefer a “proper” release off the main branch instead of a non-tested version branched off 1.9.0.
Also, is this issue actually fixed? I haven’t seen any fix/confirmation. Are the previously missing files present in the daily snapshots?