librespot: Command line arguments are incorrectly echoed in TRACE.
See this output:
[2021-12-05T12:11:07Z INFO librespot] librespot 0.3.1 7160dc1 (Built on 2021-12-05, Build ID: dLpKscF9, Profile: release)
[2021-12-05T12:11:07Z TRACE librespot] Command line argument(s):
[2021-12-05T12:11:07Z TRACE librespot] --name Speakers
[2021-12-05T12:11:07Z TRACE librespot] --backend alsa
[2021-12-05T12:11:07Z TRACE librespot] --device hw:1,0
[2021-12-05T12:11:07Z TRACE librespot] --mixer alsa
[2021-12-05T12:11:07Z TRACE librespot] --alsa-mixer-device hw:1
[2021-12-05T12:11:07Z TRACE librespot] --bitrate 320
[2021-12-05T12:11:07Z TRACE librespot] --cache /tmpfs/spotify/
[2021-12-05T12:11:07Z TRACE librespot] --cache-size-limit 512M
[2021-12-05T12:11:07Z TRACE librespot] --volume-ctrl cubic
[2021-12-05T12:11:07Z TRACE librespot] --verbose
[2021-12-05T12:11:07Z TRACE librespot] --initial-volume 100
[2021-12-05T12:11:07Z TRACE librespot] --enable-volume-normalisation
[2021-12-05T12:11:07Z TRACE librespot] --normalisation-method dynamic
[2021-12-05T12:11:07Z TRACE librespot] --normalisation-gain-type track
[2021-12-05T12:11:07Z TRACE librespot] --normalisation-pregain
[2021-12-05T12:11:07Z TRACE librespot] -3
[2021-12-05T12:11:07Z TRACE librespot] --format S24_3
[2021-12-05T12:11:07Z TRACE librespot] --username XXXXXXXX
[2021-12-05T12:11:07Z TRACE librespot] --password XXXXXXXX
[2021-12-05T12:11:07Z TRACE librespot] --autoplay
The part that says -3 belongs to the argument before that.
The argument is parsed correctly, because the other part of the log is correct:
[2021-12-05T12:11:25Z DEBUG librespot_playback::mixer::alsamixer] Alsa forcing linear dB mapping: false
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Type: Track
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Pregain: -3.0 dB
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Threshold: -2.0 dBFS
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Method: Dynamic
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Attack: 5ms
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Release: 100ms
[2021-12-05T12:11:25Z DEBUG librespot_playback::player] Normalisation Knee: 1.0
So it seems only the echo is incorrect. Minor error, but could be fixed whatsoever I believe.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 19 (13 by maintainers)
@roderickvd along the way I’ll see about making the mixer not explode on errors,lol!!